Re: [PATCH 3/3] checkincludes.pl: add option to remove duplicates in place

["Daniel K." <dk@uw.no>]

Andrew Morton wrote:
> On Wed, 5 Aug 2009 17:51:12 -0700 "Luis R. Rodriguez" <lrodriguez@Atheros.com> wrote:
>> -	print "Usage: checkincludes.pl <file list>\n";
>> +	print "Usage: checkincludes.pl [-r]\n";
>> +	print "By default we just warn of duplicates\n";
>> +	print "To remove files in place use -r\n";
> 
> I'm not sure I like the wording here - I don't _want_ my files removed!
> 
> This?
> 
> --- a/scripts/checkincludes.pl~checkincludespl-add-option-to-remove-duplicates-in-place-fix
> +++ a/scripts/checkincludes.pl
> @@ -7,7 +7,7 @@
>  sub usage {
>  	print "Usage: checkincludes.pl [-r]\n";
>  	print "By default we just warn of duplicates\n";
> -	print "To remove files in place use -r\n";
> +	print "To remove duplicated includes in place use -r\n";
>  	exit 1;
>  }
>  

And perhaps the '<file list>' should be kept as well, for documentation?

--- a/scripts/checkincludes.pl
+++ a/scripts/checkincludes.pl
@@ -5,7 +5,7 @@
 # Copyright abandoned, 2009, Luis R. Rodriguez <mcgrof@gmail.com>
 
 sub usage {
-	print "Usage: checkincludes.pl [-r]\n";
+	print "Usage: checkincludes.pl [-r] <file list>\n";
 	print "By default we just warn of duplicates\n";
 	print "To remove duplicated includes in place use -r\n";
 	exit 1;


Daniel K.