From: Brice Goglin <Brice.Goglin@inria.fr>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
paulus@samba.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Fix reading of perf.data file header
Date: Fri, 07 Aug 2009 10:18:39 +0200 [thread overview]
Message-ID: <4A7BE35F.4060604@inria.fr> (raw)
In-Reply-To: <20090807074525.GA20292@elte.hu>
Ingo Molnar wrote:
> I completely forgot about it. And since we now have --scale enabled
> by default (and it doesnt make much sense to disable it i guess), it
> would not be a big issue to rename that -c/--scale to free up that
> flag for -S/--stat?
>
> Ingo
>
Here you are. But how do you switch "scale" off now that it's disabled
by default?
I tried --scale=0, --no-scale and so on without apparently succeeding.
Brice
[PATCH] perf stat: change -S for --scale into -c
Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Index: linux-rc/tools/perf/Documentation/perf-stat.txt
===================================================================
--- linux-rc.orig/tools/perf/Documentation/perf-stat.txt 2009-08-07 10:09:40.000000000 +0200
+++ linux-rc/tools/perf/Documentation/perf-stat.txt 2009-08-07 10:09:46.000000000 +0200
@@ -40,7 +40,7 @@
-a::
system-wide collection
--S::
+-c::
scale counter values
EXAMPLES
Index: linux-rc/tools/perf/builtin-stat.c
===================================================================
--- linux-rc.orig/tools/perf/builtin-stat.c 2009-08-07 09:46:49.000000000 +0200
+++ linux-rc/tools/perf/builtin-stat.c 2009-08-07 10:07:44.000000000 +0200
@@ -496,7 +496,7 @@
"stat events on existing pid"),
OPT_BOOLEAN('a', "all-cpus", &system_wide,
"system-wide collection from all CPUs"),
- OPT_BOOLEAN('S', "scale", &scale,
+ OPT_BOOLEAN('c', "scale", &scale,
"scale/normalize counters"),
OPT_BOOLEAN('v', "verbose", &verbose,
"be more verbose (show counter open errors, etc)"),
next prev parent reply other threads:[~2009-08-07 8:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 20:54 [perf] howto switch from pfmon Brice Goglin
2009-06-23 12:12 ` Andi Kleen
2009-06-23 12:23 ` Peter Zijlstra
2009-06-23 13:57 ` Ingo Molnar
2009-06-23 13:14 ` Ingo Molnar
2009-06-23 13:22 ` Peter Zijlstra
2009-06-23 13:38 ` Ingo Molnar
2009-06-23 13:25 ` Ingo Molnar
2009-06-23 13:47 ` Ingo Molnar
2009-06-23 14:00 ` Brice Goglin
2009-06-23 14:36 ` Ingo Molnar
2009-06-23 15:22 ` Brice Goglin
2009-06-29 19:29 ` Ingo Molnar
2009-08-06 16:59 ` Brice Goglin
2009-08-06 17:40 ` Peter Zijlstra
2009-08-06 17:48 ` Brice Goglin
2009-08-06 17:59 ` Peter Zijlstra
2009-08-06 18:57 ` [PATCH] perf tools: Fix reading of perf.data file header Peter Zijlstra
2009-08-06 19:03 ` Brice Goglin
2009-08-06 19:59 ` Ingo Molnar
2009-08-06 20:03 ` Brice Goglin
2009-08-06 23:35 ` Brice Goglin
2009-08-07 6:13 ` Brice Goglin
2009-08-07 6:32 ` Ingo Molnar
2009-08-07 7:38 ` Brice Goglin
2009-08-07 7:45 ` Ingo Molnar
2009-08-07 8:18 ` Brice Goglin [this message]
2009-08-07 8:23 ` Ingo Molnar
2009-08-07 8:27 ` Ingo Molnar
2009-08-07 8:30 ` [tip:perfcounters/core] perf stat: Rename -S/--scale to -c/--scale tip-bot for Brice Goglin
2009-08-07 11:55 ` [PATCH] perf report: Display per-thread event counters Brice Goglin
2009-08-08 11:54 ` [tip:perfcounters/core] perf report: Fix and improve the displaying of " tip-bot for Brice Goglin
2009-08-08 12:14 ` [PATCH] perf report: Display " Ingo Molnar
2009-08-08 16:10 ` Brice Goglin
2009-08-08 16:13 ` Ingo Molnar
2009-08-07 6:37 ` [tip:perfcounters/urgent] perf tools: Fix multi-counter stat bug caused by incorrect reading of perf.data file header tip-bot for Peter Zijlstra
2009-08-07 7:39 ` tip-bot for Peter Zijlstra
2009-08-06 19:01 ` [perf] howto switch from pfmon Brice Goglin
2009-06-23 14:21 ` Brice Goglin
2009-06-23 14:51 ` Ingo Molnar
2009-06-23 15:29 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7BE35F.4060604@inria.fr \
--to=brice.goglin@inria.fr \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox