Re: [Patch 1/7] x86: add CONFIG_KEXEC_AUTO_RESERVE

Andi Kleen
2009-08-05T14:45:10Z

Amerigo Wang <amwang@redhat.com> writes:

> Introduce a new config option KEXEC_AUTO_RESERVE for x86.

The description of the feature belongs in the changelog.

I like the basic idea, but:

> +config KEXEC_AUTO_RESERVE
> + bool "automatically reserve memory for kexec kernel"
> + depends on KEXEC
> + default y
> + ---help---
> + Automatically reserve memory for a kexec kernel, so that you don't
> + need to specify numbers for the "crashkernel=X@Y" boot option,
> + instead you can use "crashkernel=auto".
> + On x86, 128M is reserved.

The obvious problem is the hardcoded 128MB (and 128MB is very large
for a crash kernel anyways)

More useful would seem a crashkernel=size@auto

-Andi

--
ak@linux.intel.com -- Speaking for myself only.