From: Roel Kluin <roel.kluin@gmail.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] fat: Read buffer overflow
Date: Sat, 08 Aug 2009 00:48:08 +0200 [thread overview]
Message-ID: <4A7CAF28.8020908@gmail.com> (raw)
If len is less or equal to 0, this results in a read of s[-1].
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index 6f27853..114ff6d 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -202,6 +202,9 @@ static inline int vfat_is_used_badchars(const wchar_t *s, int len)
{
int i;
+ if (len <= 0)
+ return -EINVAL;
+
for (i = 0; i < len; i++)
if (vfat_bad_char(s[i]))
return -EINVAL;
next reply other threads:[~2009-08-07 22:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 22:48 Roel Kluin [this message]
2009-08-07 23:06 ` [PATCH] fat: Read buffer overflow OGAWA Hirofumi
2009-08-08 6:56 ` Pekka Enberg
2009-08-08 10:10 ` OGAWA Hirofumi
2009-08-08 10:12 ` Pekka Enberg
2009-08-08 10:18 ` OGAWA Hirofumi
[not found] <d6Gqb-2HX-3@gated-at.bofh.it>
2009-08-08 13:01 ` Alexander Koeppe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7CAF28.8020908@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox