From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754532AbZHKPY6@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754532AbZHKPY6 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 11 Aug 2009 11:24:58 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753208AbZHKPY5
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 11 Aug 2009 11:24:57 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54442 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752565AbZHKPY5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Aug 2009 11:24:57 -0400
Message-ID: <4A818C7D.7010307@redhat.com>
Date: Tue, 11 Aug 2009 11:21:33 -0400
From: Prarit Bhargava <prarit@redhat.com>
User-Agent: Thunderbird 1.5.0.7 (X11/20061008)
MIME-Version: 1.0
To: Andi Kleen <andi@firstfloor.org>
CC: balbir@linux.vnet.ibm.com, Andrew Morton <akpm@linux-foundation.org>,
       KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
       "nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       "menage@google.com" <menage@google.com>, andi.kleen@intel.com,
       Pavel Emelianov <xemul@openvz.org>,
       "lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: Help Resource Counters Scale better (v4)
References: <20090811144405.GW7176@balbir.in.ibm.com>	<4A81863A.2050504@redhat.com> <87d472gyw9.fsf@basil.nowhere.org>
In-Reply-To: <87d472gyw9.fsf@basil.nowhere.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



Andi Kleen wrote:
> Prarit Bhargava <prarit@redhat.com> writes:
>   
>> On a 64p/32G system running 2.6.31-git2-rc5, with RESOURCE_COUNTERS
>>     
>
> This is CONFIG_RESOURCE_COUNTERS off at compile time right?
>
>   
>> off, "time make -j64" results in
>>     

^^^ yes.  It is off.

>> real    4m54.972s
>> user    90m13.456s
>> sys     50m19.711s
>>
>> On the same system, running 2.6.31-git2-rc5, with RESOURCE_COUNTERS on,
>> plus Balbir's "Help Resource Counters Scale Better (v3)" patch, and
>> this patch, results in
>>
>> real    4m18.607s
>> user    84m58.943s
>> sys     50m52.682s
>>     
>
> Hmm, so resource counters on with the patch is faster than
> CONFIG_RESOURCE_COUNTERS compiled out in real time? That seems
> counterintuitive. At best I would expect the patch to break even, but
> not be actually faster.
>   

That is only after one run.  I'm doing 10 reboot and build runs right 
now and will average them out.  I'll ping back here with results.

>
> Still it looks like the patch is clearly needed.
>
>   

P.