Re: qi_lb60_keypad driver question?

[Xiangfu Liu <xiangfu@qi-hardware.com>]

Hi Dmitry Torokhow

thanks for the reply.

Dmitry Torokhov wrote:
> Which is not telling most of the people anything. For example I have no
> idea whta .25 kernel is.
>   
we are current work on 2.6.25.20 kernel. make it work in 'Ben NanoNote' [1]
all the patch is at [2]
> There is already an updated version of matrix_keypad driver in mainline,
> you don't need to repost it.
> This should go into arch specific board setup code, not in drivers/input
>
>   
>> +
>> +static struct platform_device qi_lb60_device = {
>> +	.name		= "qi_lb60-keyboard",
>> +	.name		= "matrix-keypad",
>>     
>
> You are setting .name twice. Also, statically allocated platform devices
> may not be unregistered. Just create this device once in your board init
> code instead of having a separate unloadable module.
>   
thanks for the info.

[1]http://www.qi-hardware.com/products/ben-nanonote/
[2]http://github.com/lindnermarek/openwrt-x-burst/tree/adb28f982f25a822d2dda9aa054470f3fff02908/target/linux/xburst/patches-2.6.25
--
Xiangfu Liu 刘向富
==================================
Qi Hardware Inc.
Mobile: +86 132 4141 2371
Jabber: xiangfu.z at gmail.com
Email : xiangfu at qi-hardware.com
Web   : http://www.qi-hardware.com
==================================