From: Manfred Spraul <manfred@colorfullife.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Zach Brown <zach.brown@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nadia Derbey <Nadia.Derbey@bull.net>,
Pierre Peiffer <peifferp@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 4/4] ipc: sem optimise simple operations
Date: Wed, 12 Aug 2009 20:35:56 +0200 [thread overview]
Message-ID: <4A830B8C.5000402@colorfullife.com> (raw)
In-Reply-To: <20090812040756.GA5330@wotan.suse.de>
On 08/12/2009 06:07 AM, Nick Piggin wrote:
> A semaphore set with 250 will use 2K before, and 10K afterward. I
> don't know that it is a huge amount really, given that they also
> have to presumably be *protecting* stuff.
>
>
The allocation uses vmalloc for larger allocations, thus 10k should not
be an issue.
> We can convert them to hlists (I was going to send a patch to do
> everything in hlists, but hlists are missing some _rcu variants...
> maybe I should just convert the pending lists to start with).
>
>
Is it possible to use list_add and list_add_tail instead?
Add the "waiting for zero" to the beginning and "waiting for nonzero" to
the end.
Basically, the same approach for "simple" and "complex" operations:
- if all operations are simple operations, then all operations affect
only individual semaphores
--> use per semaphore lists
- if there is one complex operation, then the global, per
semaphore-array lists are used.
--
Manfred
next prev parent reply other threads:[~2009-08-12 18:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 11:09 [patch 0/4] ipc sem improvements npiggin
2009-08-11 11:09 ` [patch 1/4] ipc: sem optimise undo list search npiggin
2009-08-16 13:17 ` Manfred Spraul
2009-08-11 11:09 ` [patch 2/4] ipc: sem use list operations npiggin
2009-08-16 13:18 ` Manfred Spraul
2009-08-11 11:09 ` [patch 3/4] ipc: sem preempt improve npiggin
2009-08-16 13:20 ` Manfred Spraul
2009-08-11 11:09 ` [patch 4/4] ipc: sem optimise simple operations npiggin
2009-08-11 18:19 ` Manfred Spraul
2009-08-11 18:23 ` Zach Brown
2009-08-12 4:07 ` Nick Piggin
2009-08-12 18:35 ` Manfred Spraul [this message]
2009-08-14 8:58 ` Nick Piggin
2009-08-14 17:53 ` Manfred Spraul
2009-08-11 20:07 ` Cyrill Gorcunov
2009-08-12 4:48 ` Nick Piggin
2009-08-12 5:43 ` Cyrill Gorcunov
2009-08-14 18:48 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A830B8C.5000402@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=Nadia.Derbey@bull.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=peifferp@gmail.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox