From: Wan ZongShun <mcuos.com@gmail.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Add watchdog driver for w90p910
Date: Mon, 17 Aug 2009 10:40:40 +0800 [thread overview]
Message-ID: <4A88C328.5040706@gmail.com> (raw)
In-Reply-To: <4A79873A.5010504@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]
Dear Wim,
Thanks for your w90p910-v2.diff, I appreciated it.
I have tested it and only modified the quote of 'expect_close',
and now the patch works very well.:)
At the same time, I renamed this driver name, due to I
have changed the corresponding device name in my arch file.
The attached file is fixed patch relative to this w90p910-v2.diff.
Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
---
drivers/watchdog/w90p910_wdt.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/w90p910_wdt.c b/drivers/watchdog/w90p910_wdt.c
index 3cb8972..741db53 100644
--- a/drivers/watchdog/w90p910_wdt.c
+++ b/drivers/watchdog/w90p910_wdt.c
@@ -137,7 +137,7 @@ static int w90p910_wdt_open(struct inode *inode, struct file *file)
static int w90p910_wdt_close(struct inode *inode, struct file *file)
{
- if (expect_close == 42)
+ if (w90p910_wdt->expect_close == 42)
w90p910_wdt_stop();
else {
dev_crit(&w90p910_wdt->pdev->dev,
@@ -328,7 +328,7 @@ static struct platform_driver w90p910wdt_driver = {
.probe = w90p910wdt_probe,
.remove = __devexit_p(w90p910wdt_remove),
.driver = {
- .name = "w90p910-wdt",
+ .name = "nuc900-wdt",
.owner = THIS_MODULE,
},
};
@@ -350,4 +350,4 @@ MODULE_AUTHOR("Wan ZongShun <mcuos.com@gmail.com>");
MODULE_DESCRIPTION("Watchdog driver for W90P910");
MODULE_LICENSE("GPL");
MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
-MODULE_ALIAS("platform:w90p910-wdt");
+MODULE_ALIAS("platform:nuc900-wdt");
--
1.5.6.3
[-- Attachment #2: 0002-wan-fix-wim-wdt-driver.patch --]
[-- Type: text/x-patch, Size: 1198 bytes --]
Fix watchdog driver for w90p910 platform.
Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
---
drivers/watchdog/w90p910_wdt.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/w90p910_wdt.c b/drivers/watchdog/w90p910_wdt.c
index 3cb8972..741db53 100644
--- a/drivers/watchdog/w90p910_wdt.c
+++ b/drivers/watchdog/w90p910_wdt.c
@@ -137,7 +137,7 @@ static int w90p910_wdt_open(struct inode *inode, struct file *file)
static int w90p910_wdt_close(struct inode *inode, struct file *file)
{
- if (expect_close == 42)
+ if (w90p910_wdt->expect_close == 42)
w90p910_wdt_stop();
else {
dev_crit(&w90p910_wdt->pdev->dev,
@@ -328,7 +328,7 @@ static struct platform_driver w90p910wdt_driver = {
.probe = w90p910wdt_probe,
.remove = __devexit_p(w90p910wdt_remove),
.driver = {
- .name = "w90p910-wdt",
+ .name = "nuc900-wdt",
.owner = THIS_MODULE,
},
};
@@ -350,4 +350,4 @@ MODULE_AUTHOR("Wan ZongShun <mcuos.com@gmail.com>");
MODULE_DESCRIPTION("Watchdog driver for W90P910");
MODULE_LICENSE("GPL");
MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
-MODULE_ALIAS("platform:w90p910-wdt");
+MODULE_ALIAS("platform:nuc900-wdt");
--
1.5.6.3
next prev parent reply other threads:[~2009-08-17 2:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 15:06 [PATCH] Add watchdog driver for w90p910 Wan ZongShun
2009-07-30 1:17 ` Wan ZongShun
2009-07-30 5:00 ` Wim Van Sebroeck
2009-07-30 5:03 ` Wan ZongShun
2009-08-04 20:10 ` Wim Van Sebroeck
2009-08-05 2:55 ` Wan ZongShun
2009-08-05 7:08 ` Wim Van Sebroeck
2009-08-05 8:00 ` Wan ZongShun
2009-08-05 10:31 ` Wim Van Sebroeck
2009-08-05 10:44 ` Wan ZongShun
2009-08-05 13:20 ` [PATCH v2] " Wan ZongShun
2009-08-17 2:40 ` Wan ZongShun [this message]
2009-08-17 9:14 ` Wim Van Sebroeck
2009-08-17 9:19 ` Wan ZongShun
2009-08-17 10:00 ` Wan ZongShun
2009-08-17 11:02 ` Wim Van Sebroeck
2009-08-17 11:04 ` Wan ZongShun
2009-08-05 11:37 ` [PATCH] " Wan ZongShun
2009-08-20 12:16 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A88C328.5040706@gmail.com \
--to=mcuos.com@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).