From: Mario Limonciello <mario_limonciello@dell.com>
To: cezary.jackiewicz@gmail.com
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] Add rfkill support to compal-laptop
Date: Mon, 17 Aug 2009 18:27:36 -0500 [thread overview]
Message-ID: <4A89E768.7010207@dell.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 210 bytes --]
In order to be useful in modern kernels and standard interfaces,
compal-laptop should have rfkill support. This patch adds it.
--
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 02_add_rfkill_support.diff --]
[-- Type: text/x-patch; name="02_add_rfkill_support.diff", Size: 3512 bytes --]
--- drivers/platform/x86/compal-laptop.c.old 2009-08-17 07:01:36.244874430 -0500
+++ drivers/platform/x86/compal-laptop.c 2009-08-17 07:02:15.012836625 -0500
@@ -52,6 +52,7 @@
#include <linux/backlight.h>
#include <linux/platform_device.h>
#include <linux/autoconf.h>
+#include <linux/rfkill.h>
#define COMPAL_DRIVER_VERSION "0.2.6"
@@ -64,6 +65,9 @@
#define WLAN_MASK 0x01
#define BT_MASK 0x02
+static struct rfkill *wifi_rfkill;
+static struct rfkill *bluetooth_rfkill;
+
static int force;
module_param(force, bool, 0);
MODULE_PARM_DESC(force, "Force driver load, ignore DMI data");
@@ -89,6 +93,87 @@
return (int) result;
}
+static void compal_rfkill_query(struct rfkill *rfkill, void *data)
+{
+ unsigned long radio = (unsigned long) data;
+ u8 result;
+ bool blocked;
+
+ ec_read(COMPAL_EC_COMMAND_WIRELESS, &result);
+
+ if ((result & KILLSWITCH_MASK) == 0)
+ blocked = 1;
+ else if (radio == WLAN_MASK)
+ blocked = !(result & WLAN_MASK);
+ else
+ blocked = !((result & BT_MASK) >> 1);
+
+ rfkill_set_sw_state(rfkill,blocked);
+ rfkill_set_hw_state(rfkill,0);
+}
+
+static int compal_rfkill_set(void *data, bool blocked)
+{
+ unsigned long radio = (unsigned long) data;
+ u8 result, value;
+
+ ec_read(COMPAL_EC_COMMAND_WIRELESS, &result);
+
+ if ((result & KILLSWITCH_MASK) == 0)
+ return -EINVAL;
+ else {
+ if (!blocked)
+ value = (u8) (result | radio);
+ else
+ value = (u8) (result & ~radio);
+ ec_write(COMPAL_EC_COMMAND_WIRELESS, value);
+ }
+
+ return 0;
+}
+
+static const struct rfkill_ops compal_rfkill_ops = {
+ .set_block = compal_rfkill_set,
+ .query = compal_rfkill_query,
+};
+
+static int setup_rfkill(void)
+{
+ int ret;
+
+ wifi_rfkill = rfkill_alloc("compal-wifi", NULL, RFKILL_TYPE_WLAN,
+ &compal_rfkill_ops, (void *) WLAN_MASK);
+ if (!wifi_rfkill) {
+ ret = -ENOMEM;
+ goto err_wifi;
+ }
+ ret = rfkill_register(wifi_rfkill);
+ if (ret)
+ goto err_wifi;
+
+ bluetooth_rfkill = rfkill_alloc("compal-bluetooth", NULL, RFKILL_TYPE_BLUETOOTH,
+ &compal_rfkill_ops, (void *) BT_MASK);
+ if (!bluetooth_rfkill) {
+ ret = -ENOMEM;
+ goto err_bt;
+ }
+ ret = rfkill_register(bluetooth_rfkill);
+ if (ret)
+ goto err_bt;
+
+ return 0;
+err_bt:
+ rfkill_destroy(bluetooth_rfkill);
+ if (bluetooth_rfkill)
+ rfkill_unregister(bluetooth_rfkill);
+err_wifi:
+ rfkill_destroy(wifi_rfkill);
+ if (wifi_rfkill)
+ rfkill_unregister(wifi_rfkill);
+
+ return ret;
+}
+
static int set_wlan_state(int state)
{
u8 result, value;
@@ -357,6 +442,12 @@
if (!force && !dmi_check_system(compal_dmi_table))
return -ENODEV;
+ ret = setup_rfkill();
+ if (ret) {
+ printk(KERN_WARNING "compal-laptop: Unable to setup rfkill\n");
+ goto fail_rfkill;
+ }
+
/* Register backlight stuff */
if (!acpi_video_backlight_support()) {
@@ -410,6 +501,13 @@
backlight_device_unregister(compalbl_device);
+fail_rfkill:
+
+ if (wifi_rfkill)
+ rfkill_unregister(wifi_rfkill);
+ if (bluetooth_rfkill)
+ rfkill_unregister(bluetooth_rfkill);
+
return ret;
}
@@ -420,6 +518,10 @@
platform_device_unregister(compal_device);
platform_driver_unregister(&compal_driver);
backlight_device_unregister(compalbl_device);
+ if (wifi_rfkill)
+ rfkill_unregister(wifi_rfkill);
+ if (bluetooth_rfkill)
+ rfkill_unregister(bluetooth_rfkill);
printk(KERN_INFO "compal-laptop: driver unloaded.\n");
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next reply other threads:[~2009-08-17 23:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 23:27 Mario Limonciello [this message]
2009-08-18 1:24 ` [PATCH 2/3] Add rfkill support to compal-laptop Marcel Holtmann
2009-08-18 7:44 ` Alan Jenkins
2009-08-18 14:52 ` Alan Jenkins
2009-08-18 17:26 ` Mario Limonciello
2009-08-18 21:08 ` Alan Jenkins
2009-08-18 21:31 ` Johannes Berg
2009-08-18 22:00 ` Mario Limonciello
2009-08-19 8:51 ` Alan Jenkins
2009-08-19 9:01 ` Johannes Berg
2009-08-19 11:43 ` Cezary Jackiewicz
2009-08-19 16:46 ` Mario Limonciello
2009-08-19 16:57 ` Alan Jenkins
2009-08-19 17:13 ` Johannes Berg
2009-08-19 18:39 ` Mario Limonciello
2009-08-18 21:17 ` Alan Jenkins
2009-08-18 8:33 ` Alan Jenkins
2009-08-18 8:19 ` Alan Jenkins
2009-08-18 12:22 ` Alan Jenkins
-- strict thread matches above, loose matches on Subject: below --
2009-08-19 18:36 Mario Limonciello
2009-08-19 18:42 ` Johannes Berg
2009-08-19 18:47 ` Mario Limonciello
2009-08-20 8:52 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E768.7010207@dell.com \
--to=mario_limonciello@dell.com \
--cc=cezary.jackiewicz@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox