From: Jon Hunter <jon-hunter@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
John Stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH 2/2] Dynamic Tick: Allow 32-bit machines to sleep for more than 2.15 seconds
Date: Tue, 18 Aug 2009 15:52:59 -0500 [thread overview]
Message-ID: <4A8B14AB.3020707@ti.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0908182125590.3361@localhost.localdomain>
Thomas Gleixner wrote:
> On Tue, 18 Aug 2009, Jon Hunter wrote:
>> diff --git a/include/linux/clockchips.h b/include/linux/clockchips.h
>> index 3a1dbba..8154bc6 100644
>> --- a/include/linux/clockchips.h
>> +++ b/include/linux/clockchips.h
>> @@ -77,8 +77,8 @@ enum clock_event_nofitiers {
>> struct clock_event_device {
>> const char *name;
>> unsigned int features;
>> - unsigned long max_delta_ns;
>> - unsigned long min_delta_ns;
>> + unsigned long long max_delta_ns;
>> + unsigned long long min_delta_ns;
>
> Can we please use u64 for this ?
John brought this up as well. There was some discussion sometime back
about this. I did get some feedback that u64 was a different type
between ppc64 and x86-64 which was causing problems with printk. The
above variables are also used with printk in the kernel today.
See the following email:
http://marc.info/?l=linux-kernel&m=124041426203283&w=2
I am not sure if this is still the case and safer to stick with
long-long for now. Let me know your thoughts.
Cheers
Jon
next prev parent reply other threads:[~2009-08-18 20:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 17:45 [PATCH 0/2] Dynamic Tick: Enabling longer sleep times on 32-bit machines Jon Hunter
2009-08-18 17:45 ` [PATCH 1/2] Dynamic Tick: Prevent clocksource wrapping during idle Jon Hunter
2009-08-18 17:45 ` [PATCH 2/2] Dynamic Tick: Allow 32-bit machines to sleep for more than 2.15 seconds Jon Hunter
2009-08-18 19:26 ` Thomas Gleixner
2009-08-18 20:52 ` Jon Hunter [this message]
2009-11-13 19:50 ` [tip:timers/core] nohz: " tip-bot for Jon Hunter
2009-08-18 19:25 ` [PATCH 1/2] Dynamic Tick: Prevent clocksource wrapping during idle Thomas Gleixner
2009-08-18 20:42 ` Jon Hunter
2009-11-13 19:49 ` [tip:timers/core] nohz: " tip-bot for Jon Hunter
2009-11-11 20:43 ` [PATCH 0/2] Dynamic Tick: Enabling longer sleep times on 32-bit machines john stultz
2009-11-11 20:57 ` Jon Hunter
2009-11-11 22:37 ` john stultz
-- strict thread matches above, loose matches on Subject: below --
2009-07-28 0:00 [PATCH 0/2] Dynamic Tick: Enabling longer sleep times on 32-bit Jon Hunter
2009-07-28 0:00 ` [PATCH 1/2] Dynamic Tick: Prevent clocksource wrapping during idle Jon Hunter
2009-07-28 0:00 ` [PATCH 2/2] Dynamic Tick: Allow 32-bit machines to sleep for more than 2.15 seconds Jon Hunter
2009-05-27 14:49 Jon Hunter
2009-05-27 18:16 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8B14AB.3020707@ti.com \
--to=jon-hunter@ti.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox