From: David Vrabel <david.vrabel@csr.com>
To: stefani@seibold.net
Cc: Joe Perches <joe@perches.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Andi Kleen <andi@firstfloor.org>,
Amerigo Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out...
Date: Thu, 20 Aug 2009 12:28:03 +0100 [thread overview]
Message-ID: <4A8D3343.5030502@csr.com> (raw)
In-Reply-To: <20090820120310.19332j54j4mf7rry@mail.your-server.de>
stefani@seibold.net wrote:
> Zitat von David Vrabel <david.vrabel@csr.com>:
>
>> Joe Perches wrote:
>>> On Wed, 2009-08-19 at 23:00 +0200, Stefani Seibold wrote:
>>>> rename kfifo_put... into kfifo_in... to prevent miss use of old
>>>> non in kernel-tree drivers
>>>> ditto for kfifo_get... -> kfifo_out...
>>> I would have thought
>>> kfifo_put -> kfifo_out
>>> kfifo_get -> kfifo_in
>>> but maybe that's just me.
>> Use push and pull instead? In and out (whichever way) isn't obvious enough.
>>
>> David
>>
>
> As i wrote before: FIFO means first in/first out not first
> pushed/first pulled nor first put/first get
> It it logical.
In and out aren't verbs.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
'member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom'
next prev parent reply other threads:[~2009-08-20 11:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 20:49 [PATCH 0/7] kfifo: new API v0.5 Stefani Seibold
2009-08-19 20:51 ` [PATCH 1/7] kfifo: move struct kfifo in place Stefani Seibold
2009-08-19 20:53 ` [PATCH 2/7] kfifo: move out spinlock Stefani Seibold
2009-08-19 20:55 ` [PATCH 3/7] kfifo: cleanup namespace Stefani Seibold
2009-08-19 21:00 ` [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out Stefani Seibold
2009-08-19 21:03 ` Joe Perches
2009-08-19 21:08 ` Stefani Seibold
2009-08-20 9:58 ` David Vrabel
2009-08-20 10:03 ` stefani
2009-08-20 11:28 ` David Vrabel [this message]
2009-08-20 16:11 ` Andi Kleen
2009-08-19 21:03 ` [PATCH 5/7] kfifo: add DEFINE_KFIFO and friends, add very tiny functions Stefani Seibold
2009-08-19 21:04 ` [PATCH 6/7] kfifo: add kfifo_skip, kfifo_from_user and kfifo_to_user Stefani Seibold
2009-08-19 21:06 ` [PATCH 7/7] kfifo: add record handling functions Stefani Seibold
-- strict thread matches above, loose matches on Subject: below --
2009-11-20 8:15 [PATCH 0/7] kfifo: new API v0.7 Stefani Seibold
2009-11-20 8:25 ` [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out Stefani Seibold
2009-11-16 11:50 [PATCH 0/7] kfifo: new API v0.6 Stefani Seibold
2009-11-16 12:03 ` [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out Stefani Seibold
2009-08-16 20:39 [PATCH 0/7] kfifo: new API v0.4 Stefani Seibold
2009-08-16 20:53 ` [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8D3343.5030502@csr.com \
--to=david.vrabel@csr.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox