Re: [Patch 1/8] kexec: allow to shrink reserved memory

Amerigo Wang
2009-08-24T01:35:31Z

Andrew Morton wrote:
> On Fri, 21 Aug 2009 02:54:25 -0400
> Amerigo Wang <amwang@redhat.com> wrote:
>
>
>> +size_t get_crash_memory_size(void)
>> +int shrink_crash_memory(unsigned long new_size)
>>
>
> These aren't particualrly well-chosen global identifiers. It would be
> better if they were called crash_*() or kexec_*(), to make it clear
> which subsystem they belong to.
>
>

Ah, good poi nt!

How about crash_get_memory_size() and crash_shrink_memory()?

Thanks!