From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Miller, Mike (OS Dev)" <Mike.Miller@hp.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux kernel <linux-kernel@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH] cciss: memory leak in cciss_init_one()
Date: Mon, 24 Aug 2009 18:37:21 +0200 [thread overview]
Message-ID: <4A92C1C1.4010007@gmail.com> (raw)
In-Reply-To: <0F5B06BAB751E047AB5C87D1F77A778869529DACD7@GVW0547EXC.americas.hpqcorp.net>
Miller, Mike (OS Dev) a écrit :
>
>
>> -----Original Message-----
>> From: Jens Axboe [mailto:jens.axboe@oracle.com]
>> Sent: Monday, August 24, 2009 3:01 AM
>> To: Eric Dumazet
>> Cc: Andrew Morton; Miller, Mike (OS Dev); linux kernel;
>> stable@kernel.org; FUJITA Tomonori
>> Subject: Re: [PATCH] cciss: memory leak in cciss_init_one()
>>
>> On Sun, Aug 23 2009, Eric Dumazet wrote:
>>> Andrew, I originally sent this 18 days ago and got no reply
>> yet, maybe
>>> could you get the baby ?
>> I'll add it for 2.6.32.
>>
>
> I guess I'm missing something. Where is the leak?
Well...
Problem is : In normal path, kfree(inq_buff); is not called.
It is called only if a "goto clean4;" is done (error path,
and in this case, inq_buff is NULL anyway)
So we exit from cciss_init_one() without freeing
a "InquiryData_struct" structure.
I am pretty sure kmemleak would complain on this leak :)
prev parent reply other threads:[~2009-08-24 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 10:41 [PATCH] cciss: memory leak in cciss_init_one() Eric Dumazet
2009-08-23 9:02 ` Eric Dumazet
2009-08-24 8:01 ` Jens Axboe
2009-08-24 16:03 ` Miller, Mike (OS Dev)
2009-08-24 16:37 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A92C1C1.4010007@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Mike.Miller@hp.com \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox