From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: Tejun Heo <htejun@gmail.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Georgi Chulkov <g.chulkov@jacobs-university.de>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Mark Lord <liml@rtr.ca>
Subject: Re: ATA device reset, shoud I be concerned?
Date: Wed, 26 Aug 2009 23:07:01 -0400 [thread overview]
Message-ID: <4A95F855.5010706@garzik.org> (raw)
In-Reply-To: <4A95F212.5060008@gmail.com>
On 08/26/2009 10:40 PM, Robert Hancock wrote:
> On 01/21/2008 08:33 AM, Tejun Heo wrote:
>> Tejun Heo wrote:
>>> IMHO, losing media error information is much better than locking up a
>>> machine hard. We can start white listing known good controllers but I'm
>>> skeptical how much benefit it will bring.
>>
>> Just a data point, even ICHs lock up after PHY event if the wrong TF
>> register is accessed. I just don't think tempting with TF regs after
>> timeout is worth the cost.
>
> Nvidia CK804 SATA controllers appear to also explode on reading TF
> registers after media errors in certain cases. (They tend to either
> lockup the machine or throw HyperTransport timeout machine check
> exceptions). I suspect those error paths aren't well tested (except that
> it even explodes in Windows with the default Microsoft IDE driver, when
> reading a scratched DVD on a SATA drive, for example.)
Well, reading TF when DMA or other operation is enabled is a big
no-no... according to spec. If we are touching TF before data xfer
operation is completed, and host controller has a chance to receive D2H
FIS, TF is undefined (except Status, in some cases).
Jeff
next prev parent reply other threads:[~2009-08-27 3:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 22:19 ATA device reset, shoud I be concerned? Georgi Chulkov
2008-01-15 10:54 ` Andrew Morton
2008-01-15 11:35 ` Alan Cox
2008-01-21 7:56 ` Tejun Heo
2008-01-21 13:02 ` Alan Cox
2008-01-21 13:14 ` Tejun Heo
2008-01-21 14:14 ` Alan Cox
2008-01-21 14:31 ` Tejun Heo
2008-01-21 14:33 ` Tejun Heo
2008-01-21 16:44 ` Alan Cox
2009-08-27 2:40 ` Robert Hancock
2009-08-27 3:07 ` Jeff Garzik [this message]
2009-08-27 8:37 ` Alan Cox
2008-01-21 16:47 ` Alan Cox
2008-01-21 17:02 ` Tejun Heo
2008-01-21 17:27 ` Alan Cox
2008-01-22 0:31 ` Tejun Heo
2008-01-22 1:31 ` Bartlomiej Zolnierkiewicz
2008-01-22 1:36 ` Tejun Heo
2008-01-22 2:08 ` Tejun Heo
2008-01-22 1:39 ` Alan Cox
2008-01-22 20:29 ` Georgi Chulkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A95F855.5010706@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=g.chulkov@jacobs-university.de \
--cc=hancockrwd@gmail.com \
--cc=htejun@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).