From: "H. Peter Anvin" <hpa@zytor.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Avi Kivity <avi@qumranet.com>
Subject: The msr_safe functions and returning -EFAULT
Date: Sun, 30 Aug 2009 14:05:28 -0700 [thread overview]
Message-ID: <4A9AE998.4040201@zytor.com> (raw)
Right now, the *msr_safe() functions are returning -EFAULT. As far as I
can tell, this makes absolutely no sense -- EFAULT is a nonsensical
error (it means a pointer into user memory given to a system call is
invalid), and the only user that seems to use this as anything other
than a boolean is the MSR driver, which wants EIO.
Sending out an email in case I have missed any instances, but I'm
inclined to just change this to EIO globally.
Anyone has objections?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next reply other threads:[~2009-08-30 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 21:05 H. Peter Anvin [this message]
2009-09-01 0:24 ` The msr_safe functions and returning -EFAULT Jeremy Fitzhardinge
2009-09-01 0:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9AE998.4040201@zytor.com \
--to=hpa@zytor.com \
--cc=avi@qumranet.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox