From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754312AbZHaCyF (ORCPT ); Sun, 30 Aug 2009 22:54:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754303AbZHaCyE (ORCPT ); Sun, 30 Aug 2009 22:54:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9062 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754278AbZHaCyD (ORCPT ); Sun, 30 Aug 2009 22:54:03 -0400 Message-ID: <4A9B3B0B.9090009@redhat.com> Date: Sun, 30 Aug 2009 22:52:59 -0400 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 2.0.0.17 (X11/20080915) MIME-Version: 1.0 To: Vivek Goyal CC: linux-kernel@vger.kernel.org, jens.axboe@oracle.com, containers@lists.linux-foundation.org, dm-devel@redhat.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, guijianfeng@cn.fujitsu.com, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, agk@redhat.com, akpm@linux-foundation.org, peterz@infradead.org, jmarchan@redhat.com, torvalds@linux-foundation.org, mingo@elte.hu Subject: Re: [PATCH 15/23] io-controller: noop changes for hierarchical fair queuing References: <1251495072-7780-1-git-send-email-vgoyal@redhat.com> <1251495072-7780-16-git-send-email-vgoyal@redhat.com> In-Reply-To: <1251495072-7780-16-git-send-email-vgoyal@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vivek Goyal wrote: > This patch changes noop to use queue scheduling code from elevator layer. > One can go back to old noop by deselecting CONFIG_IOSCHED_NOOP_HIER. > > Signed-off-by: Nauman Rafique > Signed-off-by: Vivek Goyal Not sure why noop needs hierarchical fair queueing support, but this patch is so small we might as well take it to keep things consistent between schedulers. Acked-by: Rik van Riel -- All rights reversed.