From: Amerigo Wang <amwang@redhat.com>
To: michael@ellerman.id.au
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, Neil Horman <nhorman@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
kamezawa.hiroyu@jp.fujitsu.com, Andi Kleen <andi@firstfloor.org>,
"M. Mohan Kumar" <mohan@in.ibm.com>,
akpm@linux-foundation.org, bernhard.walle@gmx.de,
Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: Re: [Patch 0/8] V5 Implement crashkernel=auto
Date: Mon, 31 Aug 2009 11:27:07 +0800 [thread overview]
Message-ID: <4A9B430B.5060006@redhat.com> (raw)
In-Reply-To: <1251680096.5279.6.camel@concordia>
Michael Ellerman wrote:
> On Wed, 2009-08-26 at 23:15 -0400, Amerigo Wang wrote:
>
>> V4 -> V5:
>> - Rename the global functions, as suggested by Andrew.
>> - Save some macros, as suggested by Andrew.
>> - Change the high threshold, from 32G to 4G.
>> - Change the low threshold on ppc, suggested by ppc developers.
>> - Make the mm part as a seperate function, suggest by Eric.
>> - Make the IA64 code more readable.
>> - Reorder the patchset again, since review from mm people is done.
>>
>> V3 -> V4:
>> - Reorder the patches.
>> - Really free the reserved memory, instead of remapping it.
>> (Thanks to KAMEZAWA Hiroyuki!)
>> - Release the reserved memory resource when the size is 0.
>> - Use strict_strtoul() instead of simple_strtoul().
>>
>> V2 -> V3:
>> - Use more clever way to calculate reserved memory size, especially for IA64.
>> - Add that patch that implements shrinking reserved memory
>>
>> V1 -> V2:
>> - Use include/asm-generic/kexec.h, suggested by Neil.
>> - Rename a local variable, suggested by Fenghua.
>> - Fix some style problems found by checkpatch.pl.
>> - Unify the Kconfig docs.
>>
>> This series of patch implements automatically reserved memory for crashkernel,
>> by introducing a new boot option "crashkernel=auto". This idea is from Neil.
>>
>> In case of breaking user-space applications, it modifies this boot option after
>> it decides how much memory should be reserved.
>>
>> On different arch, the threshold and reserved memory size is different. Please
>> refer patch 7/8 which contains an update for the documentation.
>>
>> Patch 8/8 implements shrinking reserved memory at run-time, which is useful
>> when more than enough memory is reserved automatically.
>>
>> This patchset _is_ already tested on x86_64, IA64 and ppc64.
>>
>
> I don't want to sound like a micro-kernel zealot, I'm not, but I'm still
> unconvinced as to why the auto logic needs to go in the kernel. What is
> the compelling reason that the kernel needs to do this calculation vs
> some userspace tool? We already have the syntax that allows defining a
> different crash size depending on the size of RAM.
>
Take a look at the x86 part, it can not be done _directly_ in kernel
command line with the syntax.
prev parent reply other threads:[~2009-08-31 3:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 3:15 [Patch 0/8] V5 Implement crashkernel=auto Amerigo Wang
2009-08-27 3:15 ` [Patch 1/8] x86: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-27 3:15 ` [Patch 2/8] x86: implement crashkernel=auto Amerigo Wang
2009-08-27 3:16 ` [Patch 3/8] ia64: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-27 3:16 ` [Patch 4/8] ia64: implement crashkernel=auto Amerigo Wang
2009-08-27 4:19 ` Yu, Fenghua
2009-08-27 10:26 ` Amerigo Wang
2009-08-27 18:13 ` Yu, Fenghua
2009-08-28 10:04 ` Amerigo Wang
2009-08-28 20:08 ` Yu, Fenghua
2009-08-27 3:16 ` [Patch 5/8] powerpc: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-27 3:16 ` [Patch 6/8] powerpc: implement crashkernel=auto Amerigo Wang
2009-08-27 18:22 ` Yu, Fenghua
2009-08-27 3:16 ` [Patch 7/8] doc: update the kdump document Amerigo Wang
2009-08-27 3:17 ` [Patch 8/8] kexec: allow to shrink reserved memory Amerigo Wang
2009-08-31 0:54 ` [Patch 0/8] V5 Implement crashkernel=auto Michael Ellerman
2009-08-31 3:03 ` Eric W. Biederman
2009-08-31 3:25 ` Amerigo Wang
2009-08-31 3:27 ` Amerigo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9B430B.5060006@redhat.com \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avorontsov@ru.mvista.com \
--cc=bernhard.walle@gmx.de \
--cc=ebiederm@xmission.com \
--cc=fenghua.yu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=mingo@elte.hu \
--cc=mohan@in.ibm.com \
--cc=nhorman@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox