* [PATCH] gru: allocation may fail in quicktest1()
@ 2009-08-31 8:32 Roel Kluin
2009-08-31 12:50 ` Jack Steiner
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-31 8:32 UTC (permalink / raw)
To: Jack Steiner, Andrew Morton, LKML
The allocation may fail.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
index 79689b1..766e21e 100644
--- a/drivers/misc/sgi-gru/grukservices.c
+++ b/drivers/misc/sgi-gru/grukservices.c
@@ -937,6 +937,8 @@ static int quicktest1(unsigned long arg)
/* Need 1K cacheline aligned that does not cross page boundary */
p = kmalloc(4096, 0);
+ if (p == NULL)
+ return -ENOMEM;
mq = ALIGNUP(p, 1024);
memset(mes, 0xee, sizeof(mes));
dw = mq;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gru: allocation may fail in quicktest1()
2009-08-31 8:32 [PATCH] gru: allocation may fail in quicktest1() Roel Kluin
@ 2009-08-31 12:50 ` Jack Steiner
0 siblings, 0 replies; 2+ messages in thread
From: Jack Steiner @ 2009-08-31 12:50 UTC (permalink / raw)
To: Roel Kluin; +Cc: Andrew Morton, LKML
On Mon, Aug 31, 2009 at 10:32:15AM +0200, Roel Kluin wrote:
> The allocation may fail.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jack Steiner <steiner@sgi.com>
> ---
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 79689b1..766e21e 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -937,6 +937,8 @@ static int quicktest1(unsigned long arg)
>
> /* Need 1K cacheline aligned that does not cross page boundary */
> p = kmalloc(4096, 0);
> + if (p == NULL)
> + return -ENOMEM;
> mq = ALIGNUP(p, 1024);
> memset(mes, 0xee, sizeof(mes));
> dw = mq;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-31 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-31 8:32 [PATCH] gru: allocation may fail in quicktest1() Roel Kluin
2009-08-31 12:50 ` Jack Steiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox