From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use __pa_symbol to calculate the address of a C symbol.
Date: Mon, 31 Aug 2009 14:24:34 +0300 [thread overview]
Message-ID: <4A9BB2F2.2050909@redhat.com> (raw)
In-Reply-To: <1251702271-4797-1-git-send-email-glommer@redhat.com>
On 08/31/2009 10:04 AM, Glauber Costa wrote:
> The use of __pa() to calculate the address of a C-visible symbol
> is wrong, and can lead to unpredictable results. See arch/x86/include/asm/page.h
> for details.
>
> It should be replaced with __pa_symbol(), that does the correct math here,
> by taking relocations into account.
>
Applied, thanks.
I note that the changelog entry says nothing about what component is
involved and what the effect of the bug is. This reduces its usefulness
for someone looking over the log and trying to see if a particular bug
is fixed.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-08-31 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 7:04 [PATCH] use __pa_symbol to calculate the address of a C symbol Glauber Costa
2009-08-31 11:24 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9BB2F2.2050909@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox