The msr_safe functions and returning -EFAULT

H. Peter Anvin
2009-08-30T21:06:19Z

Right now, the *msr_safe() functions are returning -EFAULT. As far as I
can tell, this makes absolutely no sense -- EFAULT is a nonsensical
error (it means a pointer into user memory given to a system call is
invalid), and the only user that seems to use this as anything other
than a boolean is the MSR driver, which wants EIO.

Sending out an email in case I have missed any instances, but I'm
inclined to just change this to EIO globally.

Anyone has objections?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.