From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Tom Zanussi <tzanussi@gmail.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/filters: Defer pred allocation
Date: Tue, 01 Sep 2009 08:50:51 +0800 [thread overview]
Message-ID: <4A9C6FEB.40202@cn.fujitsu.com> (raw)
In-Reply-To: <20090831174107.GB6048@nowhere>
>> @@ -1094,6 +1118,10 @@ int apply_event_filter(struct ftrace_event_call *call, char *filter_string)
>>
>> mutex_lock(&event_mutex);
>>
>> + err = init_preds(call);
>> + if (err)
>> + goto out_unlock;
>
>
>
> Hmm, but what happens if the filter already has its preds initialized
> by a previous filter?
>
> The first thing that init_preds() does is:
>
> filter = call->filter = kzalloc(sizeof(*filter), GFP_KERNEL);
>
> That looks like a memory leak.
>
Oops! I thought I had added a check in it.
Thanks.
next prev parent reply other threads:[~2009-09-01 0:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 8:49 [PATCH] tracing/filters: Defer pred allocation Li Zefan
2009-08-31 8:59 ` Ingo Molnar
2009-08-31 9:06 ` Li Zefan
2009-09-01 12:58 ` Masami Hiramatsu
2009-08-31 9:00 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-08-31 17:41 ` [PATCH] " Frederic Weisbecker
2009-09-01 0:50 ` Li Zefan [this message]
2009-09-01 5:31 ` [PATCH] tracing/filters: Defer pred allocation, fix memory leak Li Zefan
2009-09-01 9:32 ` Frederic Weisbecker
2009-09-06 4:36 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-09-01 3:28 ` [PATCH] tracing/filters: Defer pred allocation Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9C6FEB.40202@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox