Re: [PATCH] tracing/filters: Defer pred allocation

Tom Zanussi
2009-09-01T03:28:33Z

On Mon, 2009-08-31 at 16:49 +0800, Li Zefan wrote:
> init_preds() allocates about 5392 bytes of memory (on x86_32) for
> a TRACE_EVENT. With my config, at system boot total memory occupied
> is:
>
> 5392 * (642 + 15) == 3459KB
>
> 642 == cat available_events | wc -l
> 15 == number of dirs in events/ftrace
>
> That's quite a lot, so we'd better defer memory allocation util
> it's needed, that's when filter is used.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Other than the leak mentioned by Frederic, it looks good to me.

Acked-by: Tom Zanussi <tzanussi@gmail.com>