From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbZIABH2 (ORCPT ); Mon, 31 Aug 2009 21:07:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752583AbZIABH1 (ORCPT ); Mon, 31 Aug 2009 21:07:27 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:57946 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751815AbZIABH1 convert rfc822-to-8bit (ORCPT ); Mon, 31 Aug 2009 21:07:27 -0400 Message-ID: <4A9C73A4.20003@cn.fujitsu.com> Date: Tue, 01 Sep 2009 09:06:44 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , David Miller , Neil Horman , Frederic Weisbecker , Wei Yongjun , Netdev , LKML Subject: Re: [PATCH resend] tracing/events: convert NAPI's tracepoint via TRACE_EVENT References: <4A9B6AA7.5020508@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Steven Rostedt wrote: > On Mon, 31 Aug 2009, Xiao Guangrong wrote: > >> - Convert NAPI's tracepoint via TRACE_EVENT macro, the output information >> like below: >> >> sshd-2503 [000] 71.920846: napi_poll: ifname=eth0 state=0 weigth=16 poll=pcnet32_poll >> sshd-2503 [000] 72.020291: napi_poll: ifname=eth0 state=0 weigth=16 poll=pcnet32_poll >> sshd-2503 [000] 72.020418: napi_poll: ifname=eth0 state=NAPI_STATE_SCHED weigth=16 poll=pcnet32_poll >> >> - Remove the "DECLARE_TRACE" definiens in include/trace/define_trace.h, >> because TRACE_EVENT not use it > > The above really needs to be in a separate patch, since it is a tracing > infrastructure change. > Hi Steven, We can't break this patch into two patches, because it's has redefined 'DECLARE_TRACE' in include/trace/define_trace.h, like below: 1: if we remove 'DECLARE_TRACE' first, then NAPI's tracepoint can't define tracepoint (it's a NAPI tracepoint's bug, see my previous patch: http://marc.info/?l=linux-kernel&m=125118032931716&w=2) 2: if we convert NAPI's tracepoint first, it can't include more TRACE_EVENT .h files in one .c file, the compiler will complain with variables redefined: include/trace/events/napi.h:15: error: redefinition of ‘__tpstrtab_napi_poll’ include/trace/events/napi.h:15: error: previous definition of ‘__tpstrtab_napi_poll’ was here include/trace/events/napi.h:15: error: redefinition of ‘__tracepoint_napi_poll’ include/trace/events/napi.h:15: error: previous definition of ‘__tracepoint_napi_poll’ was here In file included from include/trace/ftrace.h:644, So, I think we do better fix this bug early, then other people can go on his work on ftrace. Hi Neil, How do you think about this patch, can you give me some comments? Thanks, Xiao