From: Masami Hiramatsu <mhiramat@redhat.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Tom Zanussi <tzanussi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/filters: Defer pred allocation
Date: Tue, 01 Sep 2009 08:58:45 -0400 [thread overview]
Message-ID: <4A9D1A85.4000503@redhat.com> (raw)
In-Reply-To: <4A9B92A0.7020009@cn.fujitsu.com>
Li Zefan wrote:
> Ingo Molnar wrote:
>> * Li Zefan <lizf@cn.fujitsu.com> wrote:
>>
>>> init_preds() allocates about 5392 bytes of memory (on x86_32) for
>>> a TRACE_EVENT. With my config, at system boot total memory occupied
>>> is:
>>>
>>> 5392 * (642 + 15) == 3459KB
>>>
>>> 642 == cat available_events | wc -l
>>> 15 == number of dirs in events/ftrace
>>>
>>> That's quite a lot, so we'd better defer memory allocation util
>>> it's needed, that's when filter is used.
>>>
>>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>>
>> Applied, thanks!
>>
>>> tracing/kprobe needs rebase after this patch..
>>
>> You mean with many probes registered it has a lot of memory
>
> I think so, if filter is used.
>
>> footprint? Instead of a rebase a merge of tracing/core into
>> tracing/kprobes would be less intrusive.
>>
>
> Yeah, I meant this patch conflicts with some patches in
> tracing/kprobe. :)
Sure, that should be a small change. :-)
Thank you!
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-09-01 12:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 8:49 [PATCH] tracing/filters: Defer pred allocation Li Zefan
2009-08-31 8:59 ` Ingo Molnar
2009-08-31 9:06 ` Li Zefan
2009-09-01 12:58 ` Masami Hiramatsu [this message]
2009-08-31 9:00 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-08-31 17:41 ` [PATCH] " Frederic Weisbecker
2009-09-01 0:50 ` Li Zefan
2009-09-01 5:31 ` [PATCH] tracing/filters: Defer pred allocation, fix memory leak Li Zefan
2009-09-01 9:32 ` Frederic Weisbecker
2009-09-06 4:36 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-09-01 3:28 ` [PATCH] tracing/filters: Defer pred allocation Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9D1A85.4000503@redhat.com \
--to=mhiramat@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox