From: "corentin.labbe" <corentin.labbe@geomatys.fr>
To: tomaz.mertelj@guest.arnes.si
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip
Date: Wed, 02 Sep 2009 10:45:02 +0200 [thread overview]
Message-ID: <4A9E308E.60505@geomatys.fr> (raw)
In-Reply-To: <20090831_202450_066558.tomaz.mertelj@guest.arnes.si>
tomaz.mertelj@guest.arnes.si a écrit :
> I have crafted a hwmon driver for Texas Instruments amc6821 SMB-bus 2-
> channel temperature sensor, pwm controller. This is my first linux project
> so some corrections will be necessary.
>
> T. Mertelj
Hello
I have some warnings
CC drivers/hwmon/amc6821.o
drivers/hwmon/amc6821.c: In function `set_temp1_auto_point_temp':
drivers/hwmon/amc6821.c:390: warning: comparison is always true due to limited range of data type
drivers/hwmon/amc6821.c: In function `set_temp2_auto_point_temp':
drivers/hwmon/amc6821.c:391: warning: comparison is always true due to limited range of data type
drivers/hwmon/amc6821.c: In function `set_pwm1_auto_point_pwm':
drivers/hwmon/amc6821.c:408: warning: comparison is always true due to limited range of data type
drivers/hwmon/amc6821.c:419: warning: comparison is always true due to limited range of data type
you use tmp as a unsigned 8 bit so it is always >= 0 (it can't be below 0)
Prefer use:
s8 tmp;
Cordially
next prev parent reply other threads:[~2009-09-02 8:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 20:24 [PATCH] hwmon: Driver for Texas Instruments amc6821 chip tomaz.mertelj
2009-09-01 17:56 ` [lm-sensors] " Andre Prendel
2009-09-02 8:20 ` Tomaz Mertelj
2009-09-02 8:45 ` corentin.labbe [this message]
2009-09-02 23:55 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2009-09-05 12:08 tomaz.mertelj
2009-09-09 0:06 ` Andrew Morton
2009-09-09 7:34 ` [lm-sensors] " Jean Delvare
2009-09-09 8:06 ` Andrew Morton
2009-09-09 12:24 ` Tomaz Mertelj
2009-09-09 12:45 ` Jean Delvare
2009-09-21 21:44 ` Andrew Morton
2009-09-22 5:59 ` Tomaz Mertelj
2009-09-22 6:02 ` Andrew Morton
2009-09-23 9:32 tomaz.mertelj
2009-09-30 19:44 ` Andrew Morton
2009-10-01 7:42 Tomaz Mertelj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9E308E.60505@geomatys.fr \
--to=corentin.labbe@geomatys.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=tomaz.mertelj@guest.arnes.si \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox