* [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge
@ 2009-09-04 3:35 Steven Toth
2009-09-06 15:11 ` Michael Krufky
2009-09-17 13:02 ` Mauro Carvalho Chehab
0 siblings, 2 replies; 5+ messages in thread
From: Steven Toth @ 2009-09-04 3:35 UTC (permalink / raw)
To: Linux Kernel Mailing List, Mauro Carvalho Chehab
Hello Mauro,
This patch series adds support for the NXP SAA7164 PCIe A/V bridge used by the
Hauppauge HVR-2200 and HVR-2250 series of products. Support is limited to DVB-T
/ ATSC / QAM digital TV only. The driver has been in development (on and off)
for around a year and the KernelLabs saa7164-stable tree (from which this patch
set was prepared) has been in testing worldwide since approx May(?) 2009.
The project page including links for firmware downloads, MythTV and Wiki
instructions is here: http://www.kernellabs.com/blog/?page_id=17
Two general observations with the tree:
1. The driver is a little verbose during initial module load, I need to trim a
few lines of debug.
2. During 64bit compile I have one compile time warning to be addressed.
Both of these will be resolved shortly and should not stop the driver being
merged and made available to a much wider range of testers.
So, please pull from http://www.kernellabs.com/hg/~stoth/saa7164-merge
- Add the SAA7164 I2C bus identifier
- SAA7164: Add support for the NXP SAA7164 silicon
- SAA7164: Fix some 32/64bit compile time warnings
- SAA7164: Adjust I/F's to the TDA10048 enabling DVB-T lock
- SAA7164: Email address change
- SAA7164: Remove volatiles for PCI writes (coding style violation)
- SAA7164: Increase firmware load tolerance
- SAA7164: OOPS avoidance during interrupt handling
- SAA7164: Removed spurious I2C errors during driver load with DVB-T boards.
- SAA7164: Fix the 88021 definition to work with production boards.
- SAA7164: Fixed the missing eeprom parse on a specific board.
- SAA7164: Fix IRQ related system hang when firmware is not found.
- SAA7164: Fix i2c eeprom read errors during load (some boards).
- SAA7164: Ensure we specify I/F's for all bandwidths
- SAA7164: Added waitsecs module parameter
- SAA7164: Cleanup a printk
- SAA7164: Increase the firmware command timeout to avoid firmware errors.
- SAA7164: Removed a duplicate call to address any PCI quirks.
- SAA7164: IRQ / message timeout related change
- SAA7164: Removed spurious debug
- SAA7164: HVR2250 changes related to attach time tuner configuration
- SAA7164: Remove meaningless if'0 code
- SAA7164: Minor i2c assignment cleanup
- SAA7164: Ensure the HVR-2200 second tuner is configured in slave mode.
- SAA7164: Add support for a new HVR-2250 hardware revision
b/linux/Documentation/video4linux/CARDLIST.saa7164 | 8
b/linux/drivers/media/video/saa7164/Kconfig | 19
b/linux/drivers/media/video/saa7164/Makefile | 12
b/linux/drivers/media/video/saa7164/saa7164-api.c | 778 +++++++++
b/linux/drivers/media/video/saa7164/saa7164-buffer.c | 162 ++
b/linux/drivers/media/video/saa7164/saa7164-bus.c | 448 +++++
b/linux/drivers/media/video/saa7164/saa7164-cards.c | 600 +++++++
b/linux/drivers/media/video/saa7164/saa7164-cmd.c | 529 ++++++
b/linux/drivers/media/video/saa7164/saa7164-core.c | 797 ++++++++++
b/linux/drivers/media/video/saa7164/saa7164-dvb.c | 594 +++++++
b/linux/drivers/media/video/saa7164/saa7164-fw.c | 632 +++++++
b/linux/drivers/media/video/saa7164/saa7164-i2c.c | 202 ++
b/linux/drivers/media/video/saa7164/saa7164-reg.h | 183 ++
b/linux/drivers/media/video/saa7164/saa7164-types.h | 287 +++
b/linux/drivers/media/video/saa7164/saa7164.h | 405 +++++
b/v4l/scripts/saa7164.pl | 57
linux/Documentation/video4linux/CARDLIST.saa7164 | 5
linux/drivers/media/video/Kconfig | 2
linux/drivers/media/video/Makefile | 1
linux/drivers/media/video/saa7164/saa7164-api.c | 6
linux/drivers/media/video/saa7164/saa7164-buffer.c | 15
linux/drivers/media/video/saa7164/saa7164-bus.c | 6
linux/drivers/media/video/saa7164/saa7164-cards.c | 74
linux/drivers/media/video/saa7164/saa7164-cmd.c | 47
linux/drivers/media/video/saa7164/saa7164-core.c | 98 -
linux/drivers/media/video/saa7164/saa7164-dvb.c | 70
linux/drivers/media/video/saa7164/saa7164-fw.c | 10
linux/drivers/media/video/saa7164/saa7164.h | 18
linux/include/linux/i2c-id.h | 1
v4l/scripts/cardlist | 3
v4l/scripts/fix_dvb_customise.pl | 3
v4l/versions.txt | 1
32 files changed, 5956 insertions(+), 117 deletions(-)
Thanks,
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge
2009-09-04 3:35 [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge Steven Toth
@ 2009-09-06 15:11 ` Michael Krufky
2009-09-17 13:02 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 5+ messages in thread
From: Michael Krufky @ 2009-09-06 15:11 UTC (permalink / raw)
To: Steven Toth; +Cc: Linux Kernel Mailing List, Mauro Carvalho Chehab, linux-media
On Thu, Sep 3, 2009 at 11:35 PM, Steven Toth<stoth@kernellabs.com> wrote:
> Hello Mauro,
>
> This patch series adds support for the NXP SAA7164 PCIe A/V bridge used by
> the Hauppauge HVR-2200 and HVR-2250 series of products. Support is limited
> to DVB-T / ATSC / QAM digital TV only. The driver has been in development
> (on and off) for around a year and the KernelLabs saa7164-stable tree (from
> which this patch set was prepared) has been in testing worldwide since
> approx May(?) 2009.
>
> The project page including links for firmware downloads, MythTV and Wiki
> instructions is here: http://www.kernellabs.com/blog/?page_id=17
>
> Two general observations with the tree:
>
> 1. The driver is a little verbose during initial module load, I need to trim
> a few lines of debug.
> 2. During 64bit compile I have one compile time warning to be addressed.
>
> Both of these will be resolved shortly and should not stop the driver being
> merged and made available to a much wider range of testers.
>
> So, please pull from http://www.kernellabs.com/hg/~stoth/saa7164-merge
>
> - Add the SAA7164 I2C bus identifier
> - SAA7164: Add support for the NXP SAA7164 silicon
> - SAA7164: Fix some 32/64bit compile time warnings
> - SAA7164: Adjust I/F's to the TDA10048 enabling DVB-T lock
> - SAA7164: Email address change
> - SAA7164: Remove volatiles for PCI writes (coding style violation)
> - SAA7164: Increase firmware load tolerance
> - SAA7164: OOPS avoidance during interrupt handling
> - SAA7164: Removed spurious I2C errors during driver load with DVB-T
> boards.
> - SAA7164: Fix the 88021 definition to work with production boards.
> - SAA7164: Fixed the missing eeprom parse on a specific board.
> - SAA7164: Fix IRQ related system hang when firmware is not found.
> - SAA7164: Fix i2c eeprom read errors during load (some boards).
> - SAA7164: Ensure we specify I/F's for all bandwidths
> - SAA7164: Added waitsecs module parameter
> - SAA7164: Cleanup a printk
> - SAA7164: Increase the firmware command timeout to avoid firmware
> errors.
> - SAA7164: Removed a duplicate call to address any PCI quirks.
> - SAA7164: IRQ / message timeout related change
> - SAA7164: Removed spurious debug
> - SAA7164: HVR2250 changes related to attach time tuner configuration
> - SAA7164: Remove meaningless if'0 code
> - SAA7164: Minor i2c assignment cleanup
> - SAA7164: Ensure the HVR-2200 second tuner is configured in slave mode.
> - SAA7164: Add support for a new HVR-2250 hardware revision
>
> b/linux/Documentation/video4linux/CARDLIST.saa7164 | 8
> b/linux/drivers/media/video/saa7164/Kconfig | 19
> b/linux/drivers/media/video/saa7164/Makefile | 12
> b/linux/drivers/media/video/saa7164/saa7164-api.c | 778 +++++++++
> b/linux/drivers/media/video/saa7164/saa7164-buffer.c | 162 ++
> b/linux/drivers/media/video/saa7164/saa7164-bus.c | 448 +++++
> b/linux/drivers/media/video/saa7164/saa7164-cards.c | 600 +++++++
> b/linux/drivers/media/video/saa7164/saa7164-cmd.c | 529 ++++++
> b/linux/drivers/media/video/saa7164/saa7164-core.c | 797 ++++++++++
> b/linux/drivers/media/video/saa7164/saa7164-dvb.c | 594 +++++++
> b/linux/drivers/media/video/saa7164/saa7164-fw.c | 632 +++++++
> b/linux/drivers/media/video/saa7164/saa7164-i2c.c | 202 ++
> b/linux/drivers/media/video/saa7164/saa7164-reg.h | 183 ++
> b/linux/drivers/media/video/saa7164/saa7164-types.h | 287 +++
> b/linux/drivers/media/video/saa7164/saa7164.h | 405 +++++
> b/v4l/scripts/saa7164.pl | 57
> linux/Documentation/video4linux/CARDLIST.saa7164 | 5
> linux/drivers/media/video/Kconfig | 2
> linux/drivers/media/video/Makefile | 1
> linux/drivers/media/video/saa7164/saa7164-api.c | 6
> linux/drivers/media/video/saa7164/saa7164-buffer.c | 15
> linux/drivers/media/video/saa7164/saa7164-bus.c | 6
> linux/drivers/media/video/saa7164/saa7164-cards.c | 74
> linux/drivers/media/video/saa7164/saa7164-cmd.c | 47
> linux/drivers/media/video/saa7164/saa7164-core.c | 98 -
> linux/drivers/media/video/saa7164/saa7164-dvb.c | 70
> linux/drivers/media/video/saa7164/saa7164-fw.c | 10
> linux/drivers/media/video/saa7164/saa7164.h | 18
> linux/include/linux/i2c-id.h | 1
> v4l/scripts/cardlist | 3
> v4l/scripts/fix_dvb_customise.pl | 3
> v4l/versions.txt | 1
> 32 files changed, 5956 insertions(+), 117 deletions(-)
After testing this tree on my machine, I have hit some minor build
issues, none of which should prevent Steve's tree from being merged,
although it would be extremely helpful to users for my additional
fixes to be merged when Steve's tree gets merged.
Mauro, After merging Steve's tree, please pull these additional
fixes, or simply pull Steve's changesets and mine together from my
tree. Please pull from:
http://kernellabs.com/hg/~mkrufky/saa7164
for the following fixes:
- make v4l/scripts/saa7164.pl executable
- saa7164: fix Kconfig: rename DVB_FE_CUSTOMIZE to MEDIA_TUNER_CUSTOMISE
- saa7164: fix Kconfig: remove HOTPLUG dependency
- enable VIDEO_SAA7164 for 2.6.24 and later
- saa7164: fix 64bit build warning
linux/drivers/media/video/saa7164/Kconfig | 3 +--
linux/drivers/media/video/saa7164/saa7164-core.c | 2 +-
v4l/versions.txt | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
Kudos to Steve for the long and hard work spent on this saa7164 driver.
Cheers,
Mike Krufky
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge
2009-09-04 3:35 [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge Steven Toth
2009-09-06 15:11 ` Michael Krufky
@ 2009-09-17 13:02 ` Mauro Carvalho Chehab
2009-09-17 13:36 ` Steven Toth
1 sibling, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2009-09-17 13:02 UTC (permalink / raw)
To: Steven Toth; +Cc: Linux Kernel Mailing List
Em Thu, 03 Sep 2009 23:35:29 -0400
Steven Toth <stoth@kernellabs.com> escreveu:
> Hello Mauro,
>
> This patch series adds support for the NXP SAA7164 PCIe A/V bridge used by the
> Hauppauge HVR-2200 and HVR-2250 series of products. Support is limited to DVB-T
> / ATSC / QAM digital TV only. The driver has been in development (on and off)
> for around a year and the KernelLabs saa7164-stable tree (from which this patch
> set was prepared) has been in testing worldwide since approx May(?) 2009.
>
> The project page including links for firmware downloads, MythTV and Wiki
> instructions is here: http://www.kernellabs.com/blog/?page_id=17
>
> Two general observations with the tree:
>
> 1. The driver is a little verbose during initial module load, I need to trim a
> few lines of debug.
> 2. During 64bit compile I have one compile time warning to be addressed.
>
> Both of these will be resolved shortly and should not stop the driver being
> merged and made available to a much wider range of testers.
>
> So, please pull from http://www.kernellabs.com/hg/~stoth/saa7164-merge
> SAA7164: Fix i2c eeprom read errors during load (some boards).
> From: Steven Toth <stoth@kernellabs.com>
> SAA7164: Fix i2c eeprom read errors during load (some boards).
> Priority: normal
> Signed-off-by: Steven Toth <stoth@kernellabs.com>
Please don't repeat the one-line summary as description. There are several cases like the above.
> - Add the SAA7164 I2C bus identifier
--- a/linux/include/linux/i2c-id.h Thu Sep 03 09:06:34 2009 -0300
+++ b/linux/include/linux/i2c-id.h Sat May 09 12:24:12 2009 -0400
+#define I2C_HW_B_SAA7164 0x010024 /* NXP 7164 based tv cards */
Why? Are you needing to use this constant somewhere? If not, just drop it and
leave the field in blank.
Anyway, I won't delay applying it due to that. I'm committing the series. Please send a fix
later for the i2c-id above mentioned.
Thanks,
Mauro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge
2009-09-17 13:02 ` Mauro Carvalho Chehab
@ 2009-09-17 13:36 ` Steven Toth
2009-09-17 14:20 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 5+ messages in thread
From: Steven Toth @ 2009-09-17 13:36 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Kernel Mailing List
On 9/17/09 9:02 AM, Mauro Carvalho Chehab wrote:
> Em Thu, 03 Sep 2009 23:35:29 -0400
> Steven Toth<stoth@kernellabs.com> escreveu:
>
>> Hello Mauro,
>>
>> This patch series adds support for the NXP SAA7164 PCIe A/V bridge used by the
>> Hauppauge HVR-2200 and HVR-2250 series of products. Support is limited to DVB-T
>> / ATSC / QAM digital TV only. The driver has been in development (on and off)
>> for around a year and the KernelLabs saa7164-stable tree (from which this patch
>> set was prepared) has been in testing worldwide since approx May(?) 2009.
>>
>> The project page including links for firmware downloads, MythTV and Wiki
>> instructions is here: http://www.kernellabs.com/blog/?page_id=17
>>
>> Two general observations with the tree:
>>
>> 1. The driver is a little verbose during initial module load, I need to trim a
>> few lines of debug.
>> 2. During 64bit compile I have one compile time warning to be addressed.
>>
>> Both of these will be resolved shortly and should not stop the driver being
>> merged and made available to a much wider range of testers.
>>
>> So, please pull from http://www.kernellabs.com/hg/~stoth/saa7164-merge
>
>> SAA7164: Fix i2c eeprom read errors during load (some boards).
>> From: Steven Toth<stoth@kernellabs.com>
>> SAA7164: Fix i2c eeprom read errors during load (some boards).
>> Priority: normal
>> Signed-off-by: Steven Toth<stoth@kernellabs.com>
>
> Please don't repeat the one-line summary as description. There are several cases like the above.
>
>> - Add the SAA7164 I2C bus identifier
>
> --- a/linux/include/linux/i2c-id.h Thu Sep 03 09:06:34 2009 -0300
> +++ b/linux/include/linux/i2c-id.h Sat May 09 12:24:12 2009 -0400
>
> +#define I2C_HW_B_SAA7164 0x010024 /* NXP 7164 based tv cards */
>
> Why? Are you needing to use this constant somewhere? If not, just drop it and
> leave the field in blank.
>
> Anyway, I won't delay applying it due to that. I'm committing the series. Please send a fix
> later for the i2c-id above mentioned.
Thanks.
I should go back and check the other trees, if this field isn't required by the
i2c sub-system then I can remove it from a number of drivers. Of course, this
tree is fairly old and it may have already been done in the 23885 / cx88 /
au0828 tree's by the other devs. I'll look into this.
Regardless, I'll generate the i2c patch.
I also have another 2.6.31 related patch stacked up, once mkrufky's tree is also
merged. I'll issue both of these for merge later today.
Thanks again,
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge
2009-09-17 13:36 ` Steven Toth
@ 2009-09-17 14:20 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2009-09-17 14:20 UTC (permalink / raw)
To: Steven Toth; +Cc: Linux Kernel Mailing List
Em Thu, 17 Sep 2009 09:36:46 -0400
Steven Toth <stoth@kernellabs.com> escreveu:
> I should go back and check the other trees, if this field isn't required by the
> i2c sub-system then I can remove it from a number of drivers. Of course, this
> tree is fairly old and it may have already been done in the 23885 / cx88 /
> au0828 tree's by the other devs. I'll look into this.
Jean Delvare did a work of cleaning up those fields. they aren't used inside
i2c. They are meant to be used inside the drivers, for the rare situations where an
i2c driver needs to know who is the i2c adapter where it is attaching.
> Regardless, I'll generate the i2c patch.
>
> I also have another 2.6.31 related patch stacked up, once mkrufky's tree is also
> merged. I'll issue both of these for merge later today.
Ok. It were already merged.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-17 14:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-04 3:35 [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge Steven Toth
2009-09-06 15:11 ` Michael Krufky
2009-09-17 13:02 ` Mauro Carvalho Chehab
2009-09-17 13:36 ` Steven Toth
2009-09-17 14:20 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox