[-mm] warning during suspend [was: suspend race -mm regression]

[Jiri Slaby <jirislaby@gmail.com>]

On 09/05/2009 12:36 AM, Jiri Slaby wrote:
> On 09/05/2009 12:30 AM, Jiri Slaby wrote:
>> WARNING: at kernel/smp.c:124
>> __generic_smp_call_function_interrupt+0xfd/0x110()
>> Hardware name: To Be Filled By O.E.M.
>> Modules linked in: nfs lockd auth_rpcgss sunrpc ath5k ath
>> Pid: 3423, comm: pm-suspend Not tainted 2.6.31-rc8-mm1_64 #762
>> Call Trace:
>>  [<ffffffff8103fc48>] warn_slowpath_common+0x78/0xb0
>>  [<ffffffff8103fc8f>] warn_slowpath_null+0xf/0x20
>>  [<ffffffff8106950d>] __generic_smp_call_function_interrupt+0xfd/0x110
>>  [<ffffffff8106956a>] hotplug_cfd+0x4a/0xa0
>>  [<ffffffff81434e47>] notifier_call_chain+0x47/0x90
>>  [<ffffffff8105b311>] raw_notifier_call_chain+0x11/0x20
>>  [<ffffffff8141ece0>] _cpu_down+0x150/0x2d0
> 
> It's the CPU_DEAD notifier:
> ffffffff8141ecd0:       48 83 ce 07             or     $0x7,%rsi
> ffffffff8141ecd4:       48 c7 c7 08 ff 5d 81    mov
> $0xffffffff815dff08,%rdi
> ffffffff8141ecdb:       e8 20 c6 c3 ff          callq  ffffffff8105b300
> <raw_notifier_call_chain>
> ffffffff8141ece0:       3d 02 80 00 00          cmp    $0x8002,%eax

And it's due to:
generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd.patch

Should the WARN_ONs now warn only when run_callbacks is true?