public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alan Cox <alan@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH RFC] char/tty_io: fix legacy pty name when more than 256 pty devices are requested
Date: Tue, 08 Sep 2009 15:48:48 -0700	[thread overview]
Message-ID: <4AA6DF50.3030603@zytor.com> (raw)
In-Reply-To: <20090908144942.76ddf0e7@caramujo.chehab.org>

On 09/08/2009 10:49 AM, Mauro Carvalho Chehab wrote:
> 
> It is important to preserve the old nomenclature for tty/pty devices for the
> first 256 devices, to avoid breakage on existing applications and with udev.
> 
> So, in order to allow more pty devices, the nomenclature were extended for
> the devices with minor 256 or above. For those, the nomenclature will be:
> 	ttyf0000-ttfpffff	(pty slave)
> 	ptyf0000-ttyfffff	(pty master)
> 

This would seem to be a somewhat silly way to extend it, especially
given the arbitrary artificial limit of just over 2^16 entries.

If you're going to do this, I would suggest using the following
namespace, as such:

	[pt]ty[p-za-e][0-9a-f]+

	sprintf(name, "%cty%c%x", slave ? 't' : 'p',
		"pqrstuvwxyzabcde"[(index >> 4) & 15],
		((index >> 4) & ~15) | (index & 15));

No arbitrary limits, and it still extends the existing namespace with
some reasonable continuity.  It means bits [7:4] are weirdly encoded,
but we get straightforward backwards compatibility as a result.

	-hpa

  parent reply	other threads:[~2009-09-08 22:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 17:49 [PATCH RFC] char/tty_io: fix legacy pty name when more than 256 pty devices are requested Mauro Carvalho Chehab
2009-09-08 17:59 ` Alan Cox
2009-09-08 18:56   ` Mauro Carvalho Chehab
2009-09-08 18:59   ` [PATCH v2 " Mauro Carvalho Chehab
2009-09-08 22:48 ` H. Peter Anvin [this message]
2009-09-08 23:33   ` [PATCH " Mauro Carvalho Chehab
2009-09-09  0:26     ` H. Peter Anvin
2009-09-09  2:54       ` Mauro Carvalho Chehab
2009-09-09  4:46         ` H. Peter Anvin
2009-09-10  4:05           ` [PATCH] " Mauro Carvalho Chehab
2009-09-10  6:21             ` H. Peter Anvin
2009-09-10 12:33               ` Mauro Carvalho Chehab
2009-09-10 14:07                 ` Alan Cox
2009-09-10 15:57                   ` H. Peter Anvin
2009-09-10 16:08                   ` H. Peter Anvin
2009-09-10 19:12                     ` Mauro Carvalho Chehab
2009-09-10 19:17                       ` H. Peter Anvin
2009-09-10 20:05                         ` Mauro Carvalho Chehab
2009-09-10 20:35                           ` H. Peter Anvin
2009-09-10 23:23                       ` Alan Cox
2009-09-10 23:25                         ` H. Peter Anvin
2009-09-11  8:43                     ` Alan Cox
2009-09-10  4:13           ` [PATCH RFC] " Mauro Carvalho Chehab
2009-09-10  5:33             ` H. Peter Anvin
2009-09-10 12:18               ` Mauro Carvalho Chehab
2009-09-10 10:19             ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA6DF50.3030603@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox