From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbZIIBTk (ORCPT ); Tue, 8 Sep 2009 21:19:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752198AbZIIBTj (ORCPT ); Tue, 8 Sep 2009 21:19:39 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:51565 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbZIIBTj (ORCPT ); Tue, 8 Sep 2009 21:19:39 -0400 Message-ID: <4AA702A5.9090800@pobox.com> Date: Tue, 08 Sep 2009 21:19:33 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Tejun Heo CC: Atsushi Nemoto , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH #upstream-fixes] libata: fix off-by-one error in ata_tf_read_block() References: <20090815.224843.240484147.anemo@mba.ocn.ne.jp> <4A876BC3.3020407@gmail.com> <20090816.183355.89035427.anemo@mba.ocn.ne.jp> <4A87F9C1.5090601@gmail.com> In-Reply-To: <4A87F9C1.5090601@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2009 08:21 AM, Tejun Heo wrote: > ata_tf_read_block() has off-by-one error when converting CHS address > to LBA. The bug isn't very visible because ata_tf_read_block() is > used only when generating sense data for a failed RW command and CHS > addressing isn't used too often these days. > > This problem was spotted by Atsushi Nemoto. > > Signed-off-by: Tejun Heo > Reported-by: Atsushi Nemoto > --- >> Well, I expect fix by you (or other libata hackers) since I think you >> can write better warning message and changelog than me ;) > > In that case, sure. Thanks a lot for the nice spotting. :-) > > drivers/ata/libata-core.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) applied