From: "H. Peter Anvin" <hpa@zytor.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Alan Cox <alan@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty devices are requested
Date: Wed, 09 Sep 2009 23:21:54 -0700 [thread overview]
Message-ID: <4AA89B02.1050909@zytor.com> (raw)
In-Reply-To: <20090910010512.60a1f523@caramujo.chehab.org>
On 09/09/2009 09:05 PM, Mauro Carvalho Chehab wrote:
> {
> + static char ptychar[] = "pqrstuvwxyzabcde";
> +
Oh yes, this should be "static const char ...".
> + * The second nibble encoded with ptychar;
> + * The first nibble, printed in hexadecimal;
> + * The other nibbles, printed in hexadecimal.
The last two are in the wrong order (and you reversed the order of the
code from my example, which made that harder to see.)
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-09-10 6:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 17:49 [PATCH RFC] char/tty_io: fix legacy pty name when more than 256 pty devices are requested Mauro Carvalho Chehab
2009-09-08 17:59 ` Alan Cox
2009-09-08 18:56 ` Mauro Carvalho Chehab
2009-09-08 18:59 ` [PATCH v2 " Mauro Carvalho Chehab
2009-09-08 22:48 ` [PATCH " H. Peter Anvin
2009-09-08 23:33 ` Mauro Carvalho Chehab
2009-09-09 0:26 ` H. Peter Anvin
2009-09-09 2:54 ` Mauro Carvalho Chehab
2009-09-09 4:46 ` H. Peter Anvin
2009-09-10 4:05 ` [PATCH] " Mauro Carvalho Chehab
2009-09-10 6:21 ` H. Peter Anvin [this message]
2009-09-10 12:33 ` Mauro Carvalho Chehab
2009-09-10 14:07 ` Alan Cox
2009-09-10 15:57 ` H. Peter Anvin
2009-09-10 16:08 ` H. Peter Anvin
2009-09-10 19:12 ` Mauro Carvalho Chehab
2009-09-10 19:17 ` H. Peter Anvin
2009-09-10 20:05 ` Mauro Carvalho Chehab
2009-09-10 20:35 ` H. Peter Anvin
2009-09-10 23:23 ` Alan Cox
2009-09-10 23:25 ` H. Peter Anvin
2009-09-11 8:43 ` Alan Cox
2009-09-10 4:13 ` [PATCH RFC] " Mauro Carvalho Chehab
2009-09-10 5:33 ` H. Peter Anvin
2009-09-10 12:18 ` Mauro Carvalho Chehab
2009-09-10 10:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA89B02.1050909@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox