* dca: module load should not be an error message
@ 2009-09-13 16:07 Stephen Hemminger
2009-09-13 17:31 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2009-09-13 16:07 UTC (permalink / raw)
To: Maciej Sosnowski, linux-kernel; +Cc: Jeff Kirsher, Dan Williams
The message (if it must exist) should not be an error message.
IMHO such messages are useless.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
I sent patch for this previously, but it seems to have been ignored.
--- a/drivers/dca/dca-core.c 2009-09-13 09:02:25.896005620 -0700
+++ b/drivers/dca/dca-core.c 2009-09-13 09:02:50.786144428 -0700
@@ -276,7 +276,7 @@ EXPORT_SYMBOL_GPL(dca_unregister_notify)
static int __init dca_init(void)
{
- printk(KERN_ERR "dca service started, version %s\n", DCA_VERSION);
+ pr_info("dca service started, version %s\n", DCA_VERSION);
return dca_sysfs_init();
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: dca: module load should not be an error message
2009-09-13 16:07 dca: module load should not be an error message Stephen Hemminger
@ 2009-09-13 17:31 ` Dan Williams
2009-09-14 15:08 ` Sosnowski, Maciej
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2009-09-13 17:31 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Sosnowski, Maciej, linux-kernel@vger.kernel.org,
Kirsher, Jeffrey T
Stephen Hemminger wrote:
> The message (if it must exist) should not be an error message.
> IMHO such messages are useless.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> ---
> I sent patch for this previously, but it seems to have been ignored.
>
Sorry about that... applied now. There are a couple other messages in
drivers/dma/ioat/dca.c and drivers/dma/ioat/pci.c that can also be
de-clawed. I'll take care of those.
Thanks,
Dan
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: dca: module load should not be an error message
2009-09-13 17:31 ` Dan Williams
@ 2009-09-14 15:08 ` Sosnowski, Maciej
0 siblings, 0 replies; 3+ messages in thread
From: Sosnowski, Maciej @ 2009-09-14 15:08 UTC (permalink / raw)
To: Williams, Dan J, Stephen Hemminger
Cc: linux-kernel@vger.kernel.org, Kirsher, Jeffrey T
Williams, Dan J wrote:
> Stephen Hemminger wrote:
>> The message (if it must exist) should not be an error message.
>> IMHO such messages are useless.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>> ---
>> I sent patch for this previously, but it seems to have been ignored.
>>
>
> Sorry about that... applied now. There are a couple other messages in
> drivers/dma/ioat/dca.c and drivers/dma/ioat/pci.c that can also be
> de-clawed. I'll take care of those.
>
> Thanks,
> Dan
Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
Thanks,
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-14 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-13 16:07 dca: module load should not be an error message Stephen Hemminger
2009-09-13 17:31 ` Dan Williams
2009-09-14 15:08 ` Sosnowski, Maciej
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox