From: "Chris Friesen" <cfriesen@nortel.com>
To: Mike Galbraith <efault@gmx.de>
Cc: pavel@pavlinux.ru, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Network Development list <netdev@vger.kernel.org>
Subject: Re: INGO Why you remove set_user_nice() from kernel/kthread.c
Date: Mon, 14 Sep 2009 10:31:19 -0600 [thread overview]
Message-ID: <4AAE6FD7.5070401@nortel.com> (raw)
In-Reply-To: <1252943123.12986.70.camel@marge.simson.net>
On 09/14/2009 09:45 AM, Mike Galbraith wrote:
> On Mon, 2009-09-14 at 09:12 -0600, Chris Friesen wrote:
>> On 09/14/2009 08:05 AM, Mike Galbraith wrote:
>>> I did that, not Ingo, and did so because with kthreads that use
>>> diddly-spit CPU (every one I see), it's just a waste of math. What
>>> kthreads are you seeing using so much CPU that their weight is a factor?
>>> They _should_ be able to preempt and get their work done just fine
>>> without a boost.
>>
>> Under heavy network load ksoftirqd can use significant amounts of cpu.
>
> OK, that may justify a weight adjustment, since it is a proxy for many.
> Question is, does it really need it?
I guess it depends how we want it to behave by default. Likely anyone
that really cares is going to fine-tune the ksoftirqd priority level
anyways.
I've added netdev to the CC list. Maybe some of the people there have
an opinion on what the default priority should be for ksoftirqd.
Chris
next prev parent reply other threads:[~2009-09-14 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 13:42 INGO Why you remove set_user_nice() from kernel/kthread.c Pavel Vasilyev
2009-09-14 14:05 ` Mike Galbraith
2009-09-14 15:12 ` Chris Friesen
2009-09-14 15:35 ` Pavel Vasilyev
2009-09-18 9:13 ` Thomas Gleixner
2009-09-14 15:45 ` Mike Galbraith
2009-09-14 16:31 ` Chris Friesen [this message]
2009-09-14 16:36 ` Mike Galbraith
-- strict thread matches above, loose matches on Subject: below --
2009-09-19 9:18 Pavel Vasilyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAE6FD7.5070401@nortel.com \
--to=cfriesen@nortel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=pavel@pavlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox