From: Nitin Gupta <ngupta@vflare.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: justinmattock@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [mmotm] change "getline" to "get_line" to avoid C library confusion
Date: Tue, 15 Sep 2009 08:27:42 +0530 [thread overview]
Message-ID: <4AAF02A6.2040601@vflare.org> (raw)
In-Reply-To: <20090914152427.71d1fa93.akpm@linux-foundation.org>
On 09/15/2009 03:54 AM, Andrew Morton wrote:
> On Mon, 14 Sep 2009 09:29:30 +0530
> Nitin Gupta<ngupta@vflare.org> wrote:
>
>> Reintroduce this change to fix compilation error on mmotm.
>> (Original change by Justin P. Mattock)
>
> I'm all confused again. This:
>
> commit d15bd1067b1fcb2b7250d22bc0c7c7fea0b759f7
> Author: Justin P. Mattock<justinmattock@gmail.com>
> AuthorDate: Sat Mar 7 13:31:29 2009 +0100
> Commit: Sam Ravnborg<sam@ravnborg.org>
> CommitDate: Sat Mar 7 13:31:29 2009 +0100
>
> kbuild: fix C libary confusion in unifdef.c due to getline()
>
> went into mainline months ago and afaict nothing has subsequently
> changed in that area?
>
>
This is already fixed in mainline but this patch is for mmotm. On mmotm,
this change is not present. So, I'm now having compilation error while
compiling mmotm tree (not mainline):
mmotm/scripts/unifdef.c:209: error: conflicting types for ‘getline’
/usr/include/stdio.h:653: note: previous declaration of ‘getline’ was here
make[3]: *** [scripts/unifdef] Error 1
make[2]: *** [__headers] Error 2
make[1]: *** [vmlinux] Error 2
make: *** [sub-make] Error 2
Thanks,
Nitin
prev parent reply other threads:[~2009-09-15 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 3:59 [PATCH] [mmotm] change "getline" to "get_line" to avoid C library confusion Nitin Gupta
2009-09-14 22:24 ` Andrew Morton
2009-09-15 2:57 ` Nitin Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAF02A6.2040601@vflare.org \
--to=ngupta@vflare.org \
--cc=akpm@linux-foundation.org \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox