* Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
2009-09-16 7:56 ` Miroslav Rezanina
@ 2009-09-16 13:24 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2009-09-16 13:24 UTC (permalink / raw)
To: Miroslav Rezanina; +Cc: Jeremy Fitzhardinge, xen-devel, linux-kernel
. snip ..
> static void xen_vcpu_setup(int cpu)
> {
> @@ -1057,6 +1111,8 @@ static __init void xen_post_allocator_init(void)
> SetPagePinned(virt_to_page(level3_user_vsyscall));
> #endif
> xen_mark_init_mm_pinned();
> +
> +/* xen_return_unused_memory(); */
Should this be commented out? Or do you plan to provide another
patch to enable this after extensive testing?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
[not found] <1772017457.205391253162074470.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
@ 2009-09-17 4:43 ` Miroslav Rezanina
2009-09-17 4:54 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 6+ messages in thread
From: Miroslav Rezanina @ 2009-09-17 4:43 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Jeremy Fitzhardinge, xen-devel, linux-kernel
----- "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
> From: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
> To: "Miroslav Rezanina" <mrezanin@redhat.com>
> Cc: "Jeremy Fitzhardinge" <jeremy@goop.org>, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
> Sent: Wednesday, September 16, 2009 3:24:56 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
> Subject: Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
>
> . snip ..
> > static void xen_vcpu_setup(int cpu)
> > {
> > @@ -1057,6 +1111,8 @@ static __init void
> xen_post_allocator_init(void)
> > SetPagePinned(virt_to_page(level3_user_vsyscall));
> > #endif
> > xen_mark_init_mm_pinned();
> > +
> > +/* xen_return_unused_memory(); */
>
> Should this be commented out? Or do you plan to provide another
> patch to enable this after extensive testing?
>
Ups.....This should not be commented out. I will resent the patch with
correct (uncommented) line.
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
Miroslav Rezanina
Software Engineer - Virtualization Team - XEN kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
2009-09-17 4:43 ` [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor Miroslav Rezanina
@ 2009-09-17 4:54 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Fitzhardinge @ 2009-09-17 4:54 UTC (permalink / raw)
To: Miroslav Rezanina; +Cc: Konrad Rzeszutek Wilk, xen-devel, linux-kernel
On 09/16/09 21:43, Miroslav Rezanina wrote:
> Ups.....This should not be commented out. I will resent the patch with
> correct (uncommented) line.
I've already applied a variant of your patch. Check the
rebase/core-freemem branch in xen.git.
J
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
[not found] <976992170.207631253175200763.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
@ 2009-09-17 8:14 ` Miroslav Rezanina
2009-09-17 16:47 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 6+ messages in thread
From: Miroslav Rezanina @ 2009-09-17 8:14 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Konrad Rzeszutek Wilk, xen-devel, linux-kernel
Hi Jeremy,
I check your application. It won't work correctly. You are calling return_unused_memory in xen_memory_setup that is too soon.
When you are calling it, there is no hole in map in any case. Calling should be in xen_post_allocator_init function (in arch/x86/xen/mmu.c).
Mirek
----- "Jeremy Fitzhardinge" <jeremy@goop.org> wrote:
> From: "Jeremy Fitzhardinge" <jeremy@goop.org>
> To: "Miroslav Rezanina" <mrezanin@redhat.com>
> Cc: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
> Sent: Thursday, September 17, 2009 6:54:56 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
> Subject: Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
>
> On 09/16/09 21:43, Miroslav Rezanina wrote:
> > Ups.....This should not be commented out. I will resent the patch
> with
> > correct (uncommented) line.
>
> I've already applied a variant of your patch. Check the
> rebase/core-freemem branch in xen.git.
>
> J
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Miroslav Rezanina
Software Engineer - Virtualization Team - XEN kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
2009-09-17 8:14 ` Miroslav Rezanina
@ 2009-09-17 16:47 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Fitzhardinge @ 2009-09-17 16:47 UTC (permalink / raw)
To: Miroslav Rezanina; +Cc: Konrad Rzeszutek Wilk, xen-devel, linux-kernel
On 09/17/09 01:14, Miroslav Rezanina wrote:
> Hi Jeremy,
> I check your application. It won't work correctly. You are calling return_unused_memory in xen_memory_setup that is too soon.
> When you are calling it, there is no hole in map in any case. Calling should be in xen_post_allocator_init function (in arch/x86/xen/mmu.c).
>
OK. Where does the e820 map get changed in the meantime?
J
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
[not found] <625566043.266451253249879910.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
@ 2009-09-18 5:02 ` Miroslav Rezanina
0 siblings, 0 replies; 6+ messages in thread
From: Miroslav Rezanina @ 2009-09-18 5:02 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: xen-devel, linux-kernel, Konrad Rzeszutek Wilk
----- "Jeremy Fitzhardinge" <jeremy@goop.org> wrote:
> From: "Jeremy Fitzhardinge" <jeremy@goop.org>
> To: "Miroslav Rezanina" <mrezanin@redhat.com>
> Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
> Sent: Thursday, September 17, 2009 6:47:10 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
> Subject: Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor
>
> On 09/17/09 01:14, Miroslav Rezanina wrote:
> > Hi Jeremy,
> > I check your application. It won't work correctly. You are calling
> return_unused_memory in xen_memory_setup that is too soon.
> > When you are calling it, there is no hole in map in any case.
> Calling should be in xen_post_allocator_init function (in
> arch/x86/xen/mmu.c).
> >
>
> OK. Where does the e820 map get changed in the meantime?
>
xen_memory_setup just set RAM map from 0 to initial nr_pages. Only one place I'm sure map is changed is
parsing mem parameter. You mentioned that there can be other cases when some parts of map are removed.
> J
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
Miroslav Rezanina
Software Engineer - Virtualization Team - XEN kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-09-18 5:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1772017457.205391253162074470.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2009-09-17 4:43 ` [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor Miroslav Rezanina
2009-09-17 4:54 ` Jeremy Fitzhardinge
[not found] <625566043.266451253249879910.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2009-09-18 5:02 ` Miroslav Rezanina
[not found] <976992170.207631253175200763.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2009-09-17 8:14 ` Miroslav Rezanina
2009-09-17 16:47 ` Jeremy Fitzhardinge
[not found] <1582654680.152201253087647836.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2009-09-16 7:56 ` Miroslav Rezanina
2009-09-16 13:24 ` [Xen-devel] " Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox