public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: microblaze-uclinux@itee.uq.edu.au
Cc: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
	linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd
Date: Thu, 17 Sep 2009 10:56:16 +0200	[thread overview]
Message-ID: <4AB1F9B0.10103@monstr.eu> (raw)
In-Reply-To: <4AB1E78D.3070007@snapgear.com>



Greg Ungerer wrote:
> Hi Lennart,
> 
> Lennart Sorensen wrote:
>> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
>> to show kilobytes as claimed rather than number of pages.
>>
>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
> 
> Looks ok to me. I can take and push the m68knommu part separately.
> Or if Andrew wants to take it all as one, here is an:
> 
> Acked-by: Greg Ungerer <gerg@uclinux.org>

As Greg wrote. It will be the best to push it separately. IMHO it
will be faster. It is up to you. If you want to add it to microblaze
branch please send only patch for microblaze.

If not.

Acked-by: Michal Simek <monstr@monstr.eu>


Thanks,
Michal



> 
> 
> Regards
> Greg
> 
> 
>> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
>> index 9942f24..3342f49 100644
>> --- a/arch/h8300/mm/init.c
>> +++ b/arch/h8300/mm/init.c
>> @@ -170,7 +170,7 @@ void free_initrd_mem(unsigned long start, unsigned
>> long end)
>>          totalram_pages++;
>>          pages++;
>>      }
>> -    printk ("Freeing initrd memory: %dk freed\n", pages);
>> +    printk ("Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE
>> / 1024));
>>  }
>>  #endif
>>  
>> diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
>> index b1703c6..f3236d0 100644
>> --- a/arch/m68knommu/mm/init.c
>> +++ b/arch/m68knommu/mm/init.c
>> @@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned
>> long end)
>>          totalram_pages++;
>>          pages++;
>>      }
>> -    printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>> +    printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages *
>> (PAGE_SIZE / 1024));
>>  }
>>  #endif
>>  
>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>> index f207f1a..ed5f96b 100644
>> --- a/arch/microblaze/mm/init.c
>> +++ b/arch/microblaze/mm/init.c
>> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned
>> long end)
>>          totalram_pages++;
>>          pages++;
>>      }
>> -    printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>> +    printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages *
>> (PAGE_SIZE / 1024));
>>  }
>>  #endif
>>  
>>
> 

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

  reply	other threads:[~2009-09-17  8:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
2009-09-17  7:38 ` Greg Ungerer
2009-09-17  8:56   ` Michal Simek [this message]
2009-09-17 15:21     ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Lennart Sorensen
2009-09-17 15:39       ` [microblaze-uclinux] =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
2009-09-17 15:50         ` Lennart Sorensen
2009-09-17 13:23 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Yoshinori Sato
2009-09-17 15:46 ` Lennart Sorensen
2009-09-17 15:47   ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze Lennart Sorensen
2009-09-21 12:39     ` Michal Simek
2009-09-21 13:32       ` Lennart Sorensen
2009-09-21 16:34         ` Michal Simek
2009-09-21 18:03           ` Lennart Sorensen
2009-09-17 15:48 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h8300 Lennart Sorensen
2009-09-17 15:49 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu Lennart Sorensen
2009-09-18  0:58   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB1F9B0.10103@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox