Re: [PATCH 3/3] tracing/events: use list_for_entry_continue

Frederic Weisbecker
2009-09-21T18:47:48Z

On Mon, Sep 21, 2009 at 10:34:57AM +0800, Li Zefan wrote:
> Frederic Weisbecker wrote:
> > On Fri, Sep 18, 2009 at 02:07:05PM +0800, Li Zefan wrote:
> >> Simplify s_next() and t_next().
> >>
> >> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> >> ---
> >
> > Nice.
> > I wonder if that can be even more simplified with
> > the following existing seq helpers:
> >
>
> Unfortunately they can't be used here, at least they can't
> help make code simpler, because we need to skip some list
> entries.
>
> But we can add seq_list_start_at() and seq_list_next_at(),
> which take a predicate and will return an entry which matches
> the predicate. I thought about it, and I can try it out.

Why not, if the pattern is already met by other subsystems.
Otherwise I guess it's not needed.

Thanks.