From: Michal Simek <monstr@monstr.eu>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: linux-kernel@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au
Subject: Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze.
Date: Mon, 21 Sep 2009 18:34:01 +0200 [thread overview]
Message-ID: <4AB7AAF9.3070805@petalogix.com> (raw)
In-Reply-To: <20090921133203.GZ23700@csclub.uwaterloo.ca>
Lennart Sorensen wrote:
> On Mon, Sep 21, 2009 at 02:39:18PM +0200, Michal Simek wrote:
>> Added to next branch.
>>
>> There were some problems which I fixed.
>> 1. long first description
>> 2. missing microblaze: at the beginning
I want to have "microblaze:" at the beginning of email/commit message.
It is much clear for mailing list, Linus and me.
Thanks,
Michal
>
> Missing what?
>
>> 3. line longer than 80chars
>
> Hmm, I thought for sure I had checkpatch.pl claiming all my lines
> were OK. Odd. Clearly the one below is longer though. How strange.
>
>> Lennart Sorensen wrote:
>>> Fix "Freeing initrd memory:" message on microblaze to show kilobytes as
>>> claimed rather than number of pages.
>>>
>>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
>>>
>>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>>> index f207f1a..ed5f96b 100644
>>> --- a/arch/microblaze/mm/init.c
>>> +++ b/arch/microblaze/mm/init.c
>>> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>>> totalram_pages++;
>>> pages++;
>>> }
>>> - printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>>> + printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>>> }
>>> #endif
>>>
>
next prev parent reply other threads:[~2009-09-21 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
2009-09-17 7:38 ` Greg Ungerer
2009-09-17 8:56 ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
2009-09-17 15:21 ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Lennart Sorensen
2009-09-17 15:39 ` [microblaze-uclinux] =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
2009-09-17 15:50 ` Lennart Sorensen
2009-09-17 13:23 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Yoshinori Sato
2009-09-17 15:46 ` Lennart Sorensen
2009-09-17 15:47 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze Lennart Sorensen
2009-09-21 12:39 ` Michal Simek
2009-09-21 13:32 ` Lennart Sorensen
2009-09-21 16:34 ` Michal Simek [this message]
2009-09-21 18:03 ` Lennart Sorensen
2009-09-17 15:48 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h8300 Lennart Sorensen
2009-09-17 15:49 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu Lennart Sorensen
2009-09-18 0:58 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB7AAF9.3070805@petalogix.com \
--to=monstr@monstr.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=michal.simek@petalogix.com \
--cc=microblaze-uclinux@itee.uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox