From: Li Zefan <lizf@cn.fujitsu.com>
To: Daniel Walker <dwalker@fifo99.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/5] checkpatch: add a blacklist
Date: Tue, 22 Sep 2009 14:29:37 +0800 [thread overview]
Message-ID: <4AB86ED1.1040200@cn.fujitsu.com> (raw)
In-Reply-To: <1253585691-10987-3-git-send-email-dwalker@fifo99.com>
Daniel Walker wrote:
> There are times when maintainers intentially don't follow the coding
> style. When that happens it means some errors need to be ignored, so
> that other errors can be focused on.
>
> To handle that I added a blacklist to checkpatch. The blacklist holds the
> file names and errors which are ignored. The output is modified to
> remove the errors from the list and not to count them.
>
> When the blacklist kicks in there is a note that does list how many
> errors got removed and that it was due to a blacklist entry. There is
> also a new option "--noblacklist" that allows the errors to be added
> back as it was without the blacklist.
>
So, for this piece of code:
TRACE_EVENT(...
TP_fast_assign(
__entry->foo = bar( xxx );
),
)
checkpatch won't report the spaces inside bar()?
If so, I don't like this patch.
Could you just teach checkpatch to recognize those macros used
in TRACE_EVENT(), if those coding-style "errors" bother you
so much that you can't put up with them?
next prev parent reply other threads:[~2009-09-22 6:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 2:14 [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Daniel Walker
2009-09-22 2:14 ` [PATCH 2/5] checkpatch: fix hang in relative indent checking Daniel Walker
2009-09-22 2:14 ` [PATCH 3/5] checkpatch: add a blacklist Daniel Walker
2009-09-22 2:14 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Daniel Walker
2009-09-22 2:14 ` [PATCH 5/5] checkpatch: fix false EXPORT_SYMBOL warning Daniel Walker
2009-09-30 17:46 ` Andy Whitcroft
2009-10-01 14:28 ` Daniel Walker
2009-10-02 7:39 ` Andy Whitcroft
2009-09-30 17:46 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Andy Whitcroft
2009-10-01 14:26 ` Daniel Walker
2009-10-02 7:43 ` Andy Whitcroft
2009-09-22 6:29 ` Li Zefan [this message]
2009-09-30 15:27 ` [PATCH 3/5] checkpatch: add a blacklist Andy Whitcroft
2009-10-01 14:18 ` Daniel Walker
2009-10-06 19:51 ` Steven Rostedt
2009-10-06 20:50 ` Krzysztof Halasa
2009-10-07 3:52 ` Daniel Walker
2009-10-07 10:17 ` Krzysztof Halasa
2009-10-07 14:26 ` Daniel Walker
2009-10-07 14:44 ` Krzysztof Halasa
2009-10-07 14:57 ` Daniel Walker
2009-10-07 15:11 ` Alan Cox
2009-10-07 15:41 ` Daniel Walker
2009-10-07 15:52 ` Alan Cox
2009-10-07 16:11 ` Daniel Walker
2009-10-07 15:08 ` Steven Rostedt
2009-10-07 15:38 ` Daniel Walker
2009-10-07 21:30 ` Krzysztof Halasa
2009-10-07 21:58 ` Daniel Walker
2009-09-30 15:24 ` [PATCH 2/5] checkpatch: fix hang in relative indent checking Andy Whitcroft
2009-09-30 17:46 ` [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Andy Whitcroft
2009-10-01 14:20 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB86ED1.1040200@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwalker@fifo99.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).