From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Daniel Walker <dwalker@fifo99.com>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-modules@vger.org
Subject: Re: [PATCH 1/4] module: extract __ExPORT_SYMBOL from module.h into mod_export.h
Date: Tue, 22 Sep 2009 16:50:16 +0100 [thread overview]
Message-ID: <4AB8F238.3040105@tuffmail.co.uk> (raw)
In-Reply-To: <1253634337.22454.3.camel@desktop>
Daniel Walker wrote:
> On Tue, 2009-09-22 at 14:38 +0100, Alan Jenkins wrote:
>
>> +
>> +struct kernel_symbol
>> +{
>> + unsigned long value;
>> + const char *name;
>> +};
>>
>
> One relevant checkpatch error above,
>
> ERROR: open brace '{' following struct go on the same line
> #71: FILE: include/linux/mod_export.h:13:
> +struct kernel_symbol
> +{
>
> You have another similar one in patch 4 ,
>
> ERROR: else should follow close brace '}'
> #99: FILE: kernel/module.c:221:
> + }
> + else if (cmp < 0)
>
>
> Could you correct those?
>
> Daniel
>
Sure, thanks. I'll hold off on resending though, in case there are any
more radical changes needed.
Alan
next prev parent reply other threads:[~2009-09-22 15:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 13:38 module: Speed up symbol resolution during module loading Alan Jenkins
2009-09-22 13:38 ` [PATCH 1/4] module: extract __ExPORT_SYMBOL from module.h into mod_export.h Alan Jenkins
2009-09-22 14:42 ` Sam Ravnborg
2009-09-22 14:45 ` Alan Jenkins
2009-09-22 15:45 ` Daniel Walker
2009-09-22 15:50 ` Alan Jenkins [this message]
2009-09-22 15:55 ` Daniel Walker
2009-09-22 13:38 ` [PATCH 2/4] kbuild: sort the list of symbols exported by the kernel (__ksymtab) Alan Jenkins
2009-09-22 14:48 ` Sam Ravnborg
2009-09-22 15:08 ` Alan Jenkins
2009-09-23 17:38 ` Sam Ravnborg
2009-09-22 13:38 ` [PATCH 3/4] module: unexport each_symbol() Alan Jenkins
2009-09-23 17:29 ` Tim Abbott
2009-09-23 18:36 ` Alan Jenkins
2009-09-23 22:00 ` Christoph Hellwig
2009-09-24 0:15 ` Rusty Russell
2009-09-26 12:13 ` Alan Jenkins
2009-09-22 13:38 ` [PATCH 4/4] module: speed up find_symbol() using binary search on the builtin symbol tables Alan Jenkins
2009-09-23 17:28 ` [PATCH 0/2] Use generic binary search function Tim Abbott
2009-09-23 18:08 ` Alan Jenkins
2009-09-23 17:28 ` [PATCH 1/2] lib: Add generic binary search function to the kernel Tim Abbott
2009-09-24 0:11 ` Rusty Russell
2009-09-27 17:05 ` Tim Abbott
2009-11-03 15:14 ` Thiago Farina
2009-11-03 15:34 ` Alan Jenkins
2009-09-23 17:28 ` [PATCH 2/2] module: use bsearch in find_symbol_in_kernel_section Tim Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB8F238.3040105@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=dwalker@fifo99.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox