Re: [PATCH 1/4] core, x86: Add user return notifiers

Avi Kivity
2009-09-19T06:41:07Z

On 09/18/2009 09:14 PM, H. Peter Anvin wrote:
> On 09/16/2009 05:45 AM, Avi Kivity wrote:
>
>> Add a general per-cpu notifier that is called whenever the kernel is
>> about to return to userspace. The notifier uses a thread_info flag
>> and existing checks, so there is no impact on user return or context
>> switch fast paths.
>>
>> Signed-off-by: Avi Kivity<avi@redhat.com>
>>
> The concept of this patch looks entirely sane, as does the code,
> *except* for:
>
> +#include<linux/user-return-notifier.h>
>
> ... missing header file, and ...
>
> +obj-$(CONFIG_USER_RETURN_NOTIFIER) += user-return-notifier.o
>
> ... missing source file.
>
> Could you fix the patch, please?
>
>

Doh. Sent out fixed patch.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.