From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Nick Piggin <npiggin@suse.de>, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64 <linux-ia64@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] vmalloc: rename local variables vmalloc_start and vmalloc_end
Date: Wed, 23 Sep 2009 11:08:23 +0900 [thread overview]
Message-ID: <4AB98317.9090500@kernel.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0909221851380.9410@V090114053VZO-1>
Christoph Lameter wrote:
> On Tue, 22 Sep 2009, Tejun Heo wrote:
>
>> const unsigned long vmalloc_end = vmalloc_end & ~(align - 1);
>>
>> Rename local variables vmalloc_start and vmalloc_end to vm_start and
>> vm_end to avoid the collision.
>
> Could you keep vmalloc_end and vmalloc_start? vm_start and vm_end may led
> to misinterpretations as start and end of the memory area covered by the
> VM.
Hmmm... yeah, the right thing to do would be either let ia64 use
VMALLOC_END directly as variable name or let it alias an unlikely
symbol like ____vmalloc_end as macro which ends up expanding to a
seemingly normal symbol like vmalloc_end is just rude. I'll change
ia64 part.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-09-23 2:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 7:40 [PATCHSET percpu#for-next] percpu: convert ia64 to dynamic percpu and drop the old one Tejun Heo
2009-09-22 7:40 ` [PATCH 1/4] vmalloc: rename local variables vmalloc_start and vmalloc_end Tejun Heo
2009-09-22 22:52 ` Christoph Lameter
2009-09-23 2:08 ` Tejun Heo [this message]
2009-09-22 7:40 ` [PATCH 2/4] ia64: allocate percpu area for cpu0 like percpu areas for other cpus Tejun Heo
2009-09-22 22:59 ` Christoph Lameter
2009-09-23 2:11 ` Tejun Heo
2009-09-23 13:44 ` Christoph Lameter
2009-09-23 14:01 ` Tejun Heo
2009-09-23 17:17 ` Christoph Lameter
2009-09-23 22:03 ` Tejun Heo
2009-09-24 7:36 ` Christoph Lameter
2009-09-24 8:37 ` Tejun Heo
2009-09-28 15:12 ` Christoph Lameter
2009-09-22 7:40 ` [PATCH 3/4] ia64: convert to dynamic percpu allocator Tejun Heo
2009-09-22 7:40 ` [PATCH 4/4] percpu: kill legacy " Tejun Heo
2009-09-22 8:16 ` [PATCHSET percpu#for-next] percpu: convert ia64 to dynamic percpu and drop the old one Ingo Molnar
2009-09-22 20:49 ` Luck, Tony
2009-09-22 21:10 ` Luck, Tony
2009-09-22 21:24 ` Luck, Tony
2009-09-22 21:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB98317.9090500@kernel.org \
--to=tj@kernel.org \
--cc=cl@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=npiggin@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox