From: Jonathan Cameron <jic23@cam.ac.uk>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
Jean Delvare <khali@linux-fr.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"Cory T. Tusar" <ctusar@videon-central.com>,
"Trisal, Kalhan" <kalhan.trisal@intel.com>,
Len Brown <lenb@kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [RFC] [PATCH 2/2] ACPI: introduce ACPI ALS device driver
Date: Wed, 23 Sep 2009 09:11:27 +0100 [thread overview]
Message-ID: <4AB9D82F.3030706@cam.ac.uk> (raw)
In-Reply-To: <1253669192.15763.39.camel@rzhang-dt>
>> Are there any plausible race conditions associated with doing the allocation this way?
>
> well, theoretically, yes.
> simultaneous add calls may happen in hotplug case, but I don't think an
> ACPI ALS device supports hotplug.
That would make that point irrelevant!
Thinking further on this. What happens on a box that for some reason repeatedly inserts and
removes this module?
This is the sort of problem idr's are meant to overcome. They will cost you a bit
in terms of complexity though.
next prev parent reply other threads:[~2009-09-23 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 3:39 [RFC] [PATCH 2/2] ACPI: introduce ACPI ALS device driver Zhang Rui
2009-09-22 12:55 ` Jonathan Cameron
2009-09-23 1:26 ` Zhang Rui
2009-09-23 8:11 ` Jonathan Cameron [this message]
2009-09-24 2:05 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB9D82F.3030706@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=alan@linux.intel.com \
--cc=ctusar@videon-central.com \
--cc=kalhan.trisal@intel.com \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox