From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Jean Delvare <khali@linux-fr.org>,
linux-kernel@vger.kernel.org,
Vegard Nossum <vegard.nossum@gmail.com>,
Eric B Munson <ebmunson@us.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Dave Airlie <airlied@linux.ie>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
Date: Wed, 23 Sep 2009 17:13:14 +0200 [thread overview]
Message-ID: <4ABA3B0A.5010403@s5r6.in-berlin.de> (raw)
In-Reply-To: <84144f020909230021h76400174q4bb6c9bcd39d576b@mail.gmail.com>
Pekka Enberg wrote:
> On Wed, Sep 23, 2009 at 10:19 AM, Jean Delvare <khali@linux-fr.org> wrote:
[...]
>> --- linux-2.6.32-pre.orig/include/linux/kmemcheck.h 2009-09-23 08:19:34.000000000 +0200
>> +++ linux-2.6.32-pre/include/linux/kmemcheck.h 2009-09-23 09:05:30.000000000 +0200
>> @@ -145,10 +145,12 @@ static inline bool kmemcheck_is_obj_init
>>
>> #define kmemcheck_annotate_bitfield(ptr, name) \
>> do { \
>> + int _n; \
>> + \
>> if (!ptr) \
>> break; \
>> \
>> - int _n = (long) &((ptr)->name##_end) \
>> + _n = (long) &((ptr)->name##_end) \
>> - (long) &((ptr)->name##_begin); \
>> BUILD_BUG_ON(_n < 0); \
>> \
>
> Oh, I was looking at an old version. The fix looks good to me, thanks Jean!
>
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Things have been set into motion already, see akpm's comment to thread
"[PATCH] kmemcheck: clean up kmemcheck_annotate_bitfield",
http://lkml.org/lkml/2009/9/22/585
--
Stefan Richter
-=====-==--= =--= =-===
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-09-23 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 16:34 v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon Stefan Richter
2009-09-23 6:39 ` Johannes Berg
2009-09-23 7:19 ` Jean Delvare
2009-09-23 7:21 ` Pekka Enberg
2009-09-23 15:13 ` Stefan Richter [this message]
2009-09-23 8:19 ` Jean Delvare
2009-09-23 7:20 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABA3B0A.5010403@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=airlied@linux.ie \
--cc=ebmunson@us.ibm.com \
--cc=johannes@sipsolutions.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox