public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: fix htmldocs pci.c
@ 2009-09-24 13:15 Jaswinder Singh Rajput
  2009-09-24 15:54 ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-09-24 13:15 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Tiago Vignatti, Dave Airlie, Jesse Barnes,
	Randy Dunlap, linux-pci, LKML


Fix the following htmldocs warnings:

  Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
  Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
  Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
  Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Tiago Vignatti <tiago.vignatti@nokia.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/pci/pci.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 6edecff..67288ec 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
 
 /**
  * pci_set_vga_state - set VGA decode state on device and parents if requested
- * @dev the PCI device
- * @decode - true = enable decoding, false = disable decoding
- * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
- * @change_bridge - traverse ancestors and change bridges
+ * @dev: the PCI device
+ * @decode: true = enable decoding, false = disable decoding
+ * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
+ * @change_bridge: traverse ancestors and change bridges
  */
 int pci_set_vga_state(struct pci_dev *dev, bool decode,
 		      unsigned int command_bits, bool change_bridge)
-- 
1.6.0.6



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: fix htmldocs pci.c
  2009-09-24 13:15 [PATCH] PCI: fix htmldocs pci.c Jaswinder Singh Rajput
@ 2009-09-24 15:54 ` Randy Dunlap
  2009-09-25  9:48   ` Tiago Vignatti
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2009-09-24 15:54 UTC (permalink / raw)
  To: Jaswinder Singh Rajput
  Cc: Benjamin Herrenschmidt, Tiago Vignatti, Dave Airlie, Jesse Barnes,
	linux-pci, LKML

Jaswinder Singh Rajput wrote:
> Fix the following htmldocs warnings:
> 
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>

Ack, but already sent to Jesse & linux-pci mailing list.

> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Tiago Vignatti <tiago.vignatti@nokia.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/pci/pci.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 6edecff..67288ec 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
>  
>  /**
>   * pci_set_vga_state - set VGA decode state on device and parents if requested
> - * @dev the PCI device
> - * @decode - true = enable decoding, false = disable decoding
> - * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> - * @change_bridge - traverse ancestors and change bridges
> + * @dev: the PCI device
> + * @decode: true = enable decoding, false = disable decoding
> + * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> + * @change_bridge: traverse ancestors and change bridges
>   */
>  int pci_set_vga_state(struct pci_dev *dev, bool decode,
>  		      unsigned int command_bits, bool change_bridge)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: fix htmldocs pci.c
  2009-09-24 15:54 ` Randy Dunlap
@ 2009-09-25  9:48   ` Tiago Vignatti
  0 siblings, 0 replies; 3+ messages in thread
From: Tiago Vignatti @ 2009-09-25  9:48 UTC (permalink / raw)
  To: ext Randy Dunlap
  Cc: Jaswinder Singh Rajput, Benjamin Herrenschmidt, Dave Airlie,
	Jesse Barnes, linux-pci, LKML

On Thu, Sep 24, 2009 at 05:54:15PM +0200, ext Randy Dunlap wrote:
> Jaswinder Singh Rajput wrote:
> > Fix the following htmldocs warnings:
> > 
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'
> > 
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> 
> Ack, but already sent to Jesse & linux-pci mailing list.

got my Ack also.
 
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Tiago Vignatti <tiago.vignatti@nokia.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Cc: Randy Dunlap <randy.dunlap@oracle.com>
> > ---
> >  drivers/pci/pci.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 6edecff..67288ec 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
> >  
> >  /**
> >   * pci_set_vga_state - set VGA decode state on device and parents if requested
> > - * @dev the PCI device
> > - * @decode - true = enable decoding, false = disable decoding
> > - * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> > - * @change_bridge - traverse ancestors and change bridges
> > + * @dev: the PCI device
> > + * @decode: true = enable decoding, false = disable decoding
> > + * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> > + * @change_bridge: traverse ancestors and change bridges
> >   */
> >  int pci_set_vga_state(struct pci_dev *dev, bool decode,
> >  		      unsigned int command_bits, bool change_bridge)
            Tiago

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-09-25  9:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-24 13:15 [PATCH] PCI: fix htmldocs pci.c Jaswinder Singh Rajput
2009-09-24 15:54 ` Randy Dunlap
2009-09-25  9:48   ` Tiago Vignatti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox