From: Oren Laadan <orenl@librato.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Containers <containers@lists.linux-foundation.org>,
Nathan Lynch <nathanl@austin.ibm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
hpa@zytor.com, mingo@elte.hu, torvalds@linux-foundation.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [RFC][v7][PATCH 0/9] Implement clone2() system call
Date: Thu, 24 Sep 2009 19:19:19 -0400 [thread overview]
Message-ID: <4ABBFE77.30402@librato.com> (raw)
In-Reply-To: <200909250021.03535.arnd@arndb.de>
Arnd Bergmann wrote:
> On Friday 25 September 2009, Oren Laadan wrote:
>> In this form, you place a constraints on where userspace may
>> place the {parent,child}_tid variable, and require that this
>> particular clone_struct remain valid memory in the parent until
>> the child terminates. This may break existing programs that
>> use this (threads libraries ?)
>
> No existing program uses sys_clone2, and the kernel function
> may well differ from the user space calling conventions, which
> are not bound by the six-argument limitation.
>
> So a clone2 library call could set up the structure with the
> arguments to the real syscall, call into the kernel and
> copy the output data back into the pointers it was given by
> the user.
That may work well for parent_tid, however child_tid is also
kept on the task_struct and written to when the child exits,
and there is no explicit user-space wrapper on that.
Also, I may be mistaken, but I thought that the idea of these
was that the kernel writes them to user space, so other threads
may see them quickly, _before_ the parent returns to userspace;
otherwise, the parent (at the library) could himself copy the
return value.
Oren.
next prev parent reply other threads:[~2009-09-24 23:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 16:55 [RFC][v7][PATCH 0/9] Implement clone2() system call Sukadev Bhattiprolu
2009-09-24 17:00 ` [RFC][v7][PATCH 1/9]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-24 17:00 ` [RFC][v7][PATCH 2/9]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-24 17:01 ` [RFC][v7][PATCH 3/9] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-24 17:45 ` Oren Laadan
2009-09-24 17:01 ` [RFC][v7][PATCH 4/9]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-09-24 17:47 ` Oren Laadan
2009-09-24 17:01 ` [RFC][v7][PATCH 5/9]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-24 17:02 ` [RFC][v7][PATCH 6/9]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-24 17:02 ` [RFC][v7][PATCH 7/9]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-24 17:03 ` [RFC][v7][PATCH 8/9]: Define clone2() syscall Sukadev Bhattiprolu
2009-09-24 21:43 ` Arnd Bergmann
2009-09-25 8:23 ` Louis Rilling
2009-09-25 10:56 ` Louis Rilling
2009-09-29 18:05 ` Sukadev Bhattiprolu
2009-09-29 18:40 ` Roland McGrath
2009-09-29 18:44 ` H. Peter Anvin
2009-09-29 19:02 ` Arjan van de Ven
2009-09-29 19:10 ` Linus Torvalds
2009-09-29 20:02 ` H. Peter Anvin
2009-09-29 22:11 ` Linus Torvalds
2009-09-29 22:19 ` H. Peter Anvin
2009-09-30 16:15 ` Arnd Bergmann
2009-09-30 16:27 ` Linus Torvalds
2009-09-30 17:59 ` Arnd Bergmann
2009-09-30 19:14 ` Linus Torvalds
2009-09-30 6:48 ` Roland McGrath
2009-09-29 20:00 ` H. Peter Anvin
2009-09-29 21:58 ` Oren Laadan
2009-09-24 17:03 ` [RFC][v7][PATCH 9/9]: Document " Sukadev Bhattiprolu
2009-09-24 18:05 ` Randy Dunlap
2009-09-25 2:31 ` KOSAKI Motohiro
2009-09-24 17:44 ` [RFC][v7][PATCH 0/9] Implement clone2() system call Oren Laadan
2009-09-24 20:15 ` Sukadev Bhattiprolu
2009-09-24 22:06 ` Oren Laadan
2009-09-24 22:21 ` Arnd Bergmann
2009-09-24 23:19 ` Oren Laadan [this message]
2009-10-01 2:36 ` Sukadev Bhattiprolu
2009-10-01 15:19 ` Oren Laadan
2009-09-24 17:57 ` Alexey Dobriyan
2009-09-24 18:35 ` Serge E. Hallyn
2009-09-30 5:34 ` Alexey Dobriyan
2009-09-30 17:41 ` Oren Laadan
2009-10-02 20:27 ` Alexey Dobriyan
2009-10-02 21:06 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABBFE77.30402@librato.com \
--to=orenl@librato.com \
--cc=adobriyan@gmail.com \
--cc=arnd@arndb.de \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nathanl@austin.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox