public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
	Ingo Molnar <mingo@elte.hu>, Jason Baron <jbaron@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Prasanna S Panchamukhi <prasanna@in.ibm.com>,
	Rusty Lynch <rusty.lynch@intel.com>,
	Jim Keniston <jkenisto@us.ibm.com>,
	Vamsi Krishna S <vamsi_krishna@in.ibm.com>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Nathan Sidwell <nathan@codesourcery.com>,
	Dominique Toupin <dominique.toupin@ericsson.com>,
	Anton Massoud <anton.massoud@ericsson.com>,
	Richard J Moore <richardj_moore@uk.ibm.com>
Subject: Re: Immediate values
Date: Fri, 25 Sep 2009 09:19:32 -0700	[thread overview]
Message-ID: <4ABCED94.4010804@zytor.com> (raw)
In-Reply-To: <20090925121449.7bb27b61@infradead.org>

Arjan van de Ven wrote:
> On Fri, 25 Sep 2009 11:02:06 +0100
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> 
>>> Then, following your advice, kprobes should be re-designed to do a
>>> stop_machine around the int3 breakpoint insertion ? And gdb
>>> should be stopping all threads of a target process before inserting
>>> a breakpoint. Therefore, I do not seem to be the only one confused
>>> about Intel statement on this issue.
>> There was considerable discussion abut this when the kprobe stuff went
>> in. If I remember rightly it was stated by someone @intel.com then
>> that int3 was ok (even though its not strictly documented as such).
>> The same is not true for all instructions on all x86 processors
>> unfortunately.
> 
> specifically, using int3 *and then going back to the old value*.
> 

As I told Mathieu in person yesterday:

1. We have no information if this is safe or not.  It is most certainly 
not documented as safe, and trying to play language lawyer with the 
errata text is pointless, as it's trying to interpret something that 
isn't there.

2. There are some reasons to believe there might be a safe technique 
somewhere in here (the one he described is a possibility, but not the 
only one.)

3. Being able to patch code without stopping all cores has other uses, 
and so spending some time doing legwork on it is probably worth it.

4. "Someone at Intel" isn't a reference... we need to track down actual 
CPU architects with real names who can give us a thumbs up or down.

	-hpa

  reply	other threads:[~2009-09-25 16:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 12:31 Immediate values Mathieu Desnoyers
2009-09-24 12:34 ` Ingo Molnar
2009-09-24 14:02   ` Jason Baron
2009-09-24 14:10     ` H. Peter Anvin
2009-09-24 14:16     ` Mathieu Desnoyers
2009-09-24 19:16       ` Ingo Molnar
2009-09-24 19:34         ` Ingo Molnar
2009-09-25  6:51           ` Arjan van de Ven
2009-09-25  7:35             ` Mathieu Desnoyers
2009-09-25  8:25               ` Arjan van de Ven
2009-09-25 10:02               ` Alan Cox
2009-09-25 10:14                 ` Arjan van de Ven
2009-09-25 16:19                   ` H. Peter Anvin [this message]
2009-09-25 16:45                     ` Arjan van de Ven
2009-09-25 17:05                       ` H. Peter Anvin
2009-09-25 10:18                 ` Richard J Moore
2009-09-25 11:12                   ` Masami Hiramatsu
2009-09-24 14:16     ` H. Peter Anvin
2009-09-24 15:39       ` Jason Baron
2009-09-24 16:52         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABCED94.4010804@zytor.com \
    --to=hpa@zytor.com \
    --cc=ak@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=anton.massoud@ericsson.com \
    --cc=arjan@infradead.org \
    --cc=dominique.toupin@ericsson.com \
    --cc=jbaron@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=nathan@codesourcery.com \
    --cc=prasanna@in.ibm.com \
    --cc=richardj_moore@uk.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=rusty.lynch@intel.com \
    --cc=suparna@in.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=vamsi_krishna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox