public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86: unify sys_iopl
Date: Fri, 25 Sep 2009 17:22:27 -0700	[thread overview]
Message-ID: <4ABD5EC3.5040204@goop.org> (raw)
In-Reply-To: <73c1f2160909251654v1c9f8eb9k9211f1e0c5e15f67@mail.gmail.com>

On 09/25/09 16:54, Brian Gerst wrote:
> Using task_pt_regs is less effecient than getting the pointer directly
> from the syscall entry code.

(really not an issue in this case)

>   On 32-bit it probably doesn't matter too
> much, but on 64-bit, you still need the special stub code in
> entry_64.S to put the full pt_regs struct on the stack.  Changing the
> calling conventions should be a seperate patch, and should be done for
> all pt_regs-using syscalls.
>   

iopl only really cares about [er]flags, so it probably doesn't need a
full ptregs structure anyway.  But I'm not sure what changes you'd
consider for the rest of the ptregs calls; sigaltstack probably doesn't
need full ptregs either (it just updates [er]sp I think), but fork/clone
definitely do.

    J

  reply	other threads:[~2009-09-26  0:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25 22:05 [GIT PULL] x86: unify sys_iopl Jeremy Fitzhardinge
2009-09-25 22:56 ` Brian Gerst
2009-09-25 23:22   ` Jeremy Fitzhardinge
2009-09-25 23:54     ` Brian Gerst
2009-09-26  0:22       ` Jeremy Fitzhardinge [this message]
2009-10-13 10:30 ` Ingo Molnar
2009-10-13 16:24   ` H. Peter Anvin
2009-10-13 16:53     ` Jeremy Fitzhardinge
2009-10-13 17:13       ` H. Peter Anvin
2009-10-13 17:55       ` H. Peter Anvin
2009-10-13 21:27       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABD5EC3.5040204@goop.org \
    --to=jeremy@goop.org \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox