Re: [PATCH] asus_atk0110: add support for Asus P7P55D

Robert Hancock
2009-09-29T04:34:50Z

On Mon, Sep 28, 2009 at 8:20 PM, Robert Hancock <hancockrwd@gmail.com> wrote:
> On Mon, Sep 28, 2009 at 7:17 AM, Luca Tettamanti <kronos.it@gmail.com> wrote:
>> On Wed, Sep 23, 2009 at 09:18:45PM -0600, Robert Hancock wrote:
>>> On Wed, Sep 23, 2009 at 1:12 PM, Luca Tettamanti <kronos.it@gmail.com> wrote:
>>> > With P7P55D (and newer) boards Asus extended the output buffer (ASBF)
>>> > making the driver unable to read the data from the sensors.
>>> > Change the driver to use dynamic buffers (allocated by ACPI core); the
>>> > return value is cached, so the number of memory allocations is very low.
>>> >
>>> > Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
>>> > Tested-by: Robert Hancock <hancockrwd@gmail.com>
>>>
>>> I just noticed a problem (either with this patch or some other issue
>>> with the driver on this board): The readings don't seem to be
>>> updating, I get the same values all the time. (Just now I started
>>> compiling a kernel and coretemp reports temperatures in the 60 degree
>>> plus range but atk0110-acpi still reports 35 degrees as it did
>>> before..)
>>
>> Hi Robert,
>> I have a new patch for you :)
>> It contains the previous changes to handle the bigger ASBF buffer plus a new
>> method to enable the EC as suggested by Asus. Be sure to compile with
>> HWMON_DEBUG_CHIP enabled.
>
> Excellent.. seems to work now and give actually updating sensor readings :-)

Have seen a couple of these though, looks like about once an hour:

ACPI Exception: AE_TIME, Returned by Handler for [EmbeddedControl]
(20090903/evregion-424)
ACPI Error (psparse-0537): Method parse/execution failed
[\_SB_.PCI0.SBRG.ASOC.GIT6] (Node ffff88013ba778c0), AE_TIME
ACPI Error (psparse-0537): Method parse/execution failed
[\_SB_.PCI0.SBRG.ASOC.GITM] (Node ffff88013ba6ea40), AE_TIME
ATK0110 ATK0110:00: atk_read_value_new: ACPI exception: AE_TIME

Maybe sometimes the embedded controller takes longer than the timeout
to process, or something?

>
> By the way, if you have any firmware-type contacts at Asus that know
> about these boards, you might want to point them at this problem, the
> BIOS DMAR tables point to invalid locations when Intel VT-d is
> enabled. So far haven't gotten any useful response from tech support..
>
> http://www.gossamer-threads.com/lists/linux/kernel/1131574
>