Re: [PATCH] asus_atk0110: add support for Asus P7P55D

Luca Tettamanti
2009-09-28T13:40:27Z

On Mon, Sep 28, 2009 at 3:22 PM, Jean Delvare <khali@linux-fr.org> wrote:
> Hi Lucas,
>
> On Mon, 28 Sep 2009 15:17:00 +0200, Luca Tettamanti wrote:
>> I have a new patch for you :)
>> It contains the previous changes to handle the bigger ASBF buffer plus a new
>> method to enable the EC as suggested by Asus. Be sure to compile with
>> HWMON_DEBUG_CHIP enabled.
>
> Wow, that's a lot of code to just enable the EC, I hoped it would be
> more simple than this :(

A lot of that code is error checking ;-)

> Wouldn't it make sense to also disable the EC when the asus_atk0110
> driver is removed? To restore the chip to its initial state.

Yes, it makes sense.

L