From: "H. Peter Anvin" <hpa@zytor.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@tglx.de,
torvalds@linux-foundation.org
Subject: Re: [PATCH] x86: Use __builtin_memset and __builtin_memcpy for memset/memcpy
Date: Tue, 29 Sep 2009 08:32:30 -0700 [thread overview]
Message-ID: <4AC2288E.3060309@zytor.com> (raw)
In-Reply-To: <200909291444.06422.arnd@arndb.de>
On 09/29/2009 05:44 AM, Arnd Bergmann wrote:
>
> The patch looks good, but is there a reason to keep it architecture
> specific? I would guess that the same logic applies to all architectures
> with gcc-4.x and could be put into include/linux/compiler-gcc4.h.
>
Each architecture has its own implementation, and in some cases gcc will
even generate code which is illegal in the kernel. It really needs to
be enabled by each architecture.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-09-29 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 9:34 [PATCH] x86: Use __builtin_memset and __builtin_memcpy for memset/memcpy Arjan van de Ven
2009-09-28 12:21 ` Arjan van de Ven
2009-09-28 23:47 ` [tip:x86/asm] " tip-bot for Arjan van de Ven
2009-09-29 12:44 ` [PATCH] " Arnd Bergmann
2009-09-29 12:53 ` Arjan van de Ven
2009-09-29 15:32 ` H. Peter Anvin [this message]
2009-10-02 19:19 ` Andi Kleen
2009-10-02 20:04 ` H. Peter Anvin
2009-10-02 20:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC2288E.3060309@zytor.com \
--to=hpa@zytor.com \
--cc=arjan@infradead.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@tglx.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox