public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Bader <stefan.bader@canonical.com>
To: Peter Feuerer <peter@piie.net>
Cc: Borislav Petkov <petkovbb@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] acerhdf: Limit modalias matching to supported boards
Date: Wed, 30 Sep 2009 14:13:55 +0200	[thread overview]
Message-ID: <4AC34B83.6090402@canonical.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

We got reports of acerhdf issuing warnings on Acer laptops other than Aspire 
Ones. Looking at the dmi match this sounds a bit to generic. IOW the module 
gets loaded on any Acer laptop. After the following patch the module gets still 
loaded on my Aspire One but not on the reported other laptop.
The same change might be helpful for the other two dmi matches, but I had no 
way of testing.

-Stefan


[-- Attachment #2: 0001-acerhdf-Limit-modalias-matching-to-supporte.patch --]
[-- Type: text/x-diff, Size: 1358 bytes --]

>From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boards

BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958

The module alias currently matches any Acer computer but when loaded the
BIOS checks will only succeed on Aspire One models. This causes a invalid
BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the
moule alias to models starting with AOA. Probably the same change should be
made for the two other entries.

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 drivers/platform/x86/acerhdf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index aa298d6..763f233 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
 MODULE_ALIAS("dmi:*:*Gateway*:*:");
 MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
 
-- 
1.5.4.5


             reply	other threads:[~2009-09-30 12:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 12:13 Stefan Bader [this message]
2009-09-30 21:22 ` [PATCH] acerhdf: Limit modalias matching to supported boards Borislav Petkov
2009-10-02  6:50   ` Peter Feuerer
2009-10-02  7:51     ` Stefan Bader
2009-10-02  9:54       ` Borislav Petkov
2009-10-02 10:04         ` Peter Feuerer
2009-10-02 10:06           ` Stefan Bader
2009-10-03 16:47             ` Peter Feuerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC34B83.6090402@canonical.com \
    --to=stefan.bader@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@piie.net \
    --cc=petkovbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox